Skip to content

Commit e663d9b

Browse files
authored
Merge pull request #960 from JuliaRobotics/23Q1/enh/blobentry
switching to Blob and BlobEntry
2 parents 3fcf785 + 4983456 commit e663d9b

File tree

3 files changed

+11
-6
lines changed

3 files changed

+11
-6
lines changed

src/DataBlobs/services/AbstractDataEntries.jl

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,10 @@ end
147147

148148
"""
149149
$(SIGNATURES)
150-
List the data entries associated with a particular variable.
150+
List the blob entries associated with a particular variable.
151+
152+
DevNotes
153+
- TODO rename to listBlobEntries (drop noun Data in lower level calls)
151154
"""
152155
function listDataEntries(var::AbstractDFGVariable)
153156
collect(keys(var.dataDict))

src/DataBlobs/services/DataEntryBlob.jl

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,9 @@ Related
6969
[`updateDataEntry!`](@ref)
7070
7171
$(METHODLIST)
72+
73+
DevNotes
74+
- TODO TBD update verb on data since data blobs and entries are restricted to immutable only.
7275
"""
7376
function updateData! end
7477

src/services/AbstractDFG.jl

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -466,20 +466,19 @@ end
466466
##------------------------------------------------------------------------------
467467
"""
468468
$(SIGNATURES)
469-
Get a list of IDs of the DFGVariables in the DFG.
469+
Get a list of labels of the DFGVariables in the graph.
470470
Optionally specify a label regular expression to retrieves a subset of the variables.
471471
Tags is a list of any tags that a node must have (at least one match).
472472
473-
NOtes
473+
Notes
474474
- Returns `::Vector{Symbol}`
475475
476476
Example
477477
```julia
478478
listVariables(dfg, r"l", tags=[:APRILTAG;])
479479
```
480480
481-
Related:
482-
- ls
481+
See also: [`ls`](@ref)
483482
"""
484483
function listVariables( dfg::AbstractDFG,
485484
regexFilter::Union{Nothing, Regex}=nothing;
@@ -502,7 +501,7 @@ end
502501

503502
"""
504503
$(SIGNATURES)
505-
Get a list of the IDs (labels) of the DFGFactors in the DFG.
504+
Get a list of the labels of the DFGFactors in the DFG.
506505
Optionally specify a label regular expression to retrieves a subset of the factors.
507506
"""
508507
function listFactors(dfg::G, regexFilter::Union{Nothing, Regex}=nothing; tags::Vector{Symbol}=Symbol[], solvable::Int=0)::Vector{Symbol} where G <: AbstractDFG

0 commit comments

Comments
 (0)