Deprecate lsfWho for lsf close #707

Author: Affie

src/Deprecated.jl

@@ -4,6 +4,8 @@
 ##=================================================================================
 @deprecate getBlobEntry(var::AbstractDFGVariable, key::AbstractString) getBlobEntryFirst(var, Regex(key))
 
+@deprecate lsfWho(dfg::AbstractDFG, type::Symbol) lsf(dfg, getfield(Main, type))
+
 ## ================================================================================
 ## Deprecated in v0.23
 ##=================================================================================

src/DistributedFactorGraphs.jl

@@ -286,7 +286,7 @@ export isValidLabel
 ## List
 export ls, lsf, ls2
 export lsTypes, lsfTypes, lsTypesDict, lsfTypesDict
-export lsWho, lsfWho
+export lsWho
 export isPrior, lsfPriors
 export hasTags, hasTagsNeighbors
 

src/services/AbstractDFG.jl

@@ -775,6 +775,15 @@ function ls(dfg::G, ::Type{T}) where {G <: AbstractDFG, T <: AbstractFactor}
     return map(x -> x.label, vxx)
 end
 
+"""
+    $(SIGNATURES)
+Lists the factors of a specific type in the factor graph. 
+Example, list all the Point2Point2 factors in the factor graph `dfg`:
+    lsfWho(dfg, :Point2Point2)
+
+Notes
+- Return `Vector{Symbol}`
+"""
 function lsf(dfg::G, ::Type{T}) where {G <: AbstractDFG, T <: AbstractFactor}
     return ls(dfg, T)
 end
@@ -837,32 +846,6 @@ function lsWho(dfg::AbstractDFG, type::Symbol)
     return labels
 end
 
-"""
-    $(SIGNATURES)
-Gives back all factor labels that fit the bill:
-    lsfWho(dfg, :Point2Point2)
-
-Notes
-- Returns `Vector{Symbol}`
-
-Dev Notes
-- Cloud versions will benefit from less data transfer
- - `ls(dfg::C, ::T) where {C <: CloudDFG, T <: ..}`
-
-Related
-
-ls, lsf, lsfPriors
-"""
-function lsfWho(dfg::AbstractDFG, type::Symbol)
-    facs = getFactors(dfg)
-    labels = Symbol[]
-    for f in facs
-        facType = typeof(getFactorType(f)) |> nameof
-        facType == type && push!(labels, f.label)
-    end
-    return labels
-end
-
 ## list types
 ##-----------
 

test/iifInterfaceTests.jl

@@ -157,7 +157,6 @@ end
 
     @test ls(dfg, LinearRelative) == [:abf1]
     @test lsf(dfg, LinearRelative) == [:abf1]
-    @test lsfWho(dfg, :LinearRelative) == [:abf1]
 
     @test getVariableType(v1) isa Position{1}
     @test getVariableType(dfg, :a) isa Position{1}

test/testBlocks.jl

@@ -1207,7 +1207,6 @@ function testGroup!(fg, v1, v2, f0, f1)
 
         @test ls(fg, TestFunctorInferenceType1) == [:abf1]
         @test lsf(fg, TestAbstractPrior) == [:af1]
-        @test lsfWho(fg, :TestFunctorInferenceType1) == [:abf1]
 
         @test getVariableType(v1) == TestVariableType1()
         @test getVariableType(fg, :a) == TestVariableType1()