GraphsDFG robot,user,session ids and minor updates

Author: Affie

src/Common.jl

@@ -5,7 +5,7 @@ export getData
 export getVariableType, getSofttype
 export getFactorType, getfnctype
 export lsTypes, lsfTypes
-
+export lsWho, lsfWho
 
 """
     $(SIGNATURES)

src/GraphsDFG/entities/GraphsDFG.jl

@@ -11,14 +11,21 @@ const FGType = Graphs.GenericIncidenceList{GraphsNode,Graphs.Edge{GraphsNode},Di
 mutable struct GraphsDFG{T <: AbstractParams} <: AbstractDFG
     g::FGType
     description::String
+    userId::String
+    robotId::String
+    sessionId::String
     nodeCounter::Int64
     labelDict::Dict{Symbol, Int64}
     addHistory::Vector{Symbol} #TODO: Discuss more - is this an audit trail?
     solverParams::T # Solver parameters
-    GraphsDFG{T}(g::FGType=Graphs.incdict(GraphsNode,is_directed=false),
-                 d::String="Graphs.jl implementation",
-                 n::Int64=0,
-                 l::Dict{Symbol, Int64}=Dict{Symbol, Int64}(),
-                 a::Vector{Symbol}=Symbol[];
-                 params::T=NoSolverParams()) where T <: AbstractParams = new{T}(g, d, n, l, a, params)
 end
+
+GraphsDFG{T}(   g::FGType=Graphs.incdict(GraphsNode,is_directed=false),
+                d::String="Graphs.jl implementation",
+                n::Int64=0,
+                l::Dict{Symbol, Int64}=Dict{Symbol, Int64}(),
+                a::Vector{Symbol}=Symbol[];
+                userId::String = "UserID",
+                robotId::String = "robotID",
+                sessionId::String = "sessionID",
+                params::T=NoSolverParams()) where T <: AbstractParams = GraphsDFG{T}(g, d, userId, robotId, sessionId, n, l, a, params)

src/LightDFG/entities/LightDFG.jl

@@ -24,7 +24,9 @@ function LightDFG{T,V,F}(g::FactorGraph{Int,V,F}=FactorGraph{Int,V,F}();
     LightDFG{T,V,F}(g, description, userId, robotId, sessionId, Symbol[], params)
 end
 
-LightDFG{T}(g::FactorGraph{Int,DFGVariable,DFGFactor}=FactorGraph{Int,DFGVariable,DFGFactor}(); kwargs...) where T <: AbstractParams = LightDFG{T,DFGVariable,DFGFactor}(g, kwargs...)
+# LightDFG{T}(; kwargs...) where T <: AbstractParams = LightDFG{T,DFGVariable,DFGFactor}(;kwargs...)
+
+LightDFG{T}(g::FactorGraph{Int,DFGVariable,DFGFactor}=FactorGraph{Int,DFGVariable,DFGFactor}(); kwargs...) where T <: AbstractParams = LightDFG{T,DFGVariable,DFGFactor}(g; kwargs...)
 
 Base.propertynames(x::LightDFG, private::Bool=false) =
     (:g, :description, :userId, :robotId, :sessionId, :nodeCounter, :labelDict, :addHistory, :solverParams)

src/SymbolDFG/entities/SymbolDFG.jl

@@ -24,7 +24,7 @@ function SymbolDFG{T,V,F}(g::SymbolFactorGraph{V,F}=SymbolFactorGraph{V,F}();
     SymbolDFG{T,V,F}(g, description, userId, robotId, sessionId, Symbol[], params)
 end
 
-SymbolDFG{T}(g::SymbolFactorGraph{DFGVariable,DFGFactor}=SymbolFactorGraph{DFGVariable,DFGFactor}(); kwargs...) where T <: AbstractParams = SymbolDFG{T,DFGVariable,DFGFactor}(g, kwargs...)
+SymbolDFG{T}(g::SymbolFactorGraph{DFGVariable,DFGFactor}=SymbolFactorGraph{DFGVariable,DFGFactor}(); kwargs...) where T <: AbstractParams = SymbolDFG{T,DFGVariable,DFGFactor}(g; kwargs...)
 
 Base.propertynames(x::SymbolDFG, private::Bool=false) =
     (:g, :description, :userId, :robotId, :sessionId, :nodeCounter, :labelDict, :addHistory, :solverParams)