Merge pull request #297 from JuliaRobotics/maint/20q1/dep_fncargvID##288

Start deprecate on field fncargvID close #288

Author: Affie

src/CommonAccessors.jl

@@ -37,11 +37,10 @@ getTimestamp(v::DataLevel1) = v.timestamp
 """
 $SIGNATURES
 
-Set the timestamp of a DFGFactor object.
-Dev note:
-Since it is not mutable it has to return a new variable with the updated timestamp.
+Set the timestamp of a DFGVariable object returning a new DFGVariable.
+Note:
+Since `timestamp` is not mutable `setTimestamp` returns a new variable with the updated timestamp.
 Use `updateVariable!` to update it in the factor graph.
-TODO either this or we should make the field/variable mutable
 """
 function setTimestamp(v::DFGVariable, ts::DateTime)
     return DFGVariable(v.label, ts, v.tags, v.ppeDict, v.solverDataDict, v.smallData, v.bigData, v._dfgNodeParams)

src/entities/DFGFactor.jl

@@ -30,6 +30,20 @@ mutable struct GenericFunctionNodeData{T, S}
     # GenericFunctionNodeData(x1, x2, x3, x4, x5::S, x6::T, x7::String) where {T, S} = new{T,S}(x1, x2, x3, x4, x5, x6, x7)
 end
 
+Base.getproperty(x::GenericFunctionNodeData,f::Symbol) = begin
+    f == :fncargvID && Base.depwarn("GenericFunctionNodeData field fncargvID will be deprecated, use `getVariableOrder` instead",:getproperty)#@warn "fncargvID is deprecated, use `getVariableOrder` instead"
+
+    getfield(x, f)
+
+  end
+
+Base.setproperty!(x::GenericFunctionNodeData,f::Symbol, val) = begin
+    f == :fncargvID && Base.depwarn("GenericFunctionNodeData field fncargvID will be deprecated, use `getVariableOrder` instead",:getproperty)#@warn "fncargvID is deprecated, use `getVariableOrder` instead"
+
+    setfield!(x,f,val)
+
+  end
+
 """
 $(TYPEDEF)
 Complete factor structure for a DistributedFactorGraph factor.