Skip to content

Commit f62ef85

Browse files
committed
fix #441
1 parent 3d5edc7 commit f62ef85

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

src/services/AbstractDFG.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,11 @@ getSolverParams(dfg::AbstractDFG) = dfg.solverParams
5454

5555
"""
5656
$(SIGNATURES)
57+
58+
Method must be overloaded by the user for Serialization to work. E.g. IncrementalInference uses `CommonConvWrapper <: FactorOperationalMemory`.
5759
"""
58-
getFactorOperationalMemoryType(par::AbstractParams) = par.factorOperationalMemoryType
60+
getFactorOperationalMemoryType(dummy) = error("Please define this function getFactorOperationalMemoryType for your usecase, e.g. = `IIF.CommonConvWrapper <: FactorOperationalMemory`")
5961

60-
getFactorOperationalMemoryType(dfg::AbstractDFG) = getFactorOperationalMemoryType(getSolverParams(dfg))
6162

6263
##------------------------------------------------------------------------------
6364
## Setters

test/testBlocks.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,8 @@ struct TestCCW{T} <: FactorOperationalMemory where {T<:FunctorInferenceType}
6161
end
6262
Base.:(==)(a::TestCCW, b::TestCCW) = a.usrfnc! == b.usrfnc!
6363

64-
DFG.getFactorOperationalMemoryType(par::NoSolverParams) = TestCCW
64+
# DF, dropping DFG. so that Main context is used and can be overridden by IIF.getFac...Type
65+
getFactorOperationalMemoryType(par::NoSolverParams) = TestCCW
6566

6667
function Base.convert(::Type{DFG.FunctionNodeData{TestCCW{F}}},
6768
d::DFG.PackedFunctionNodeData{<:PackedInferenceType}) where F<:FunctorInferenceType

0 commit comments

Comments
 (0)