Merge pull request #620 from JuliaRobotics/depr/20Q3/leave_depr_longer

Put back some deprecated for a bit longer and backward compat for loadDFG

Author: Affie

src/Deprecated.jl

@@ -1,12 +1,21 @@
 ##==============================================================================
 # deprecation staging area
 ##==============================================================================
-
 ##==============================================================================
-## Remove in 0.11
+## Deprecated in v0.9 Remove in the v0.10 cycle
 ##==============================================================================
 
-@deprecate listSolvekeys(x...; kwargs...) listSolveKeys(x...;kwargs...)
+Base.promote_rule(::Type{DateTime}, ::Type{ZonedDateTime}) = DateTime
+function Base.convert(::Type{DateTime}, ts::ZonedDateTime)
+    @warn "DFG now uses ZonedDateTime, temporary promoting and converting to DateTime local time"
+    return DateTime(ts, Local)
+end
+
+@deprecate listSolvekeys(x...) listSolveKeys(x...)
+
+##==============================================================================
+## Deprecated in v0.10 Remove in 0.11
+##==============================================================================
 
 @deprecate addVariableSolverData!(dfg::AbstractDFG, variablekey::Symbol, vnd::VariableNodeData, solveKey::Symbol) addVariableSolverData!(dfg, variablekey, vnd)
 

src/services/Serialization.jl

@@ -190,7 +190,9 @@ function unpackVariableNodeData(dfg::G, d::PackedVariableNodeData)::VariableNode
 
   @debug "Dispatching conversion packed variable -> variable for type $(string(d.softtype))"
   # Figuring out the softtype
-  st =  getTypeFromSerializationModule(d.softtype)
+  # TODO deprecated remove in v0.11 - for backward compatibility for saved softtypes. 
+  ststring = string(split(d.softtype, "(")[1])
+  st =  getTypeFromSerializationModule(ststring)
   isnothing(st) && error("The variable doesn't seem to have a softtype. It needs to set up with an InferenceVariable from IIF. This will happen if you use DFG to add serialized variables directly and try use them. Please use IncrementalInference.addVariable().")
 
   return VariableNodeData{st}(M3,M4, d.BayesNetOutVertIDs,