Skip to content

Commit 4ac23b2

Browse files
authored
Merge pull request #1690 from JuliaRobotics/23Q1/enh/testsnotbroken
tests not broken w dfg 20
2 parents 8120845 + 96a21f2 commit 4ac23b2

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ name = "IncrementalInference"
22
uuid = "904591bb-b899-562f-9e6f-b8df64c7d480"
33
keywords = ["MM-iSAMv2", "Bayes tree", "junction tree", "Bayes network", "variable elimination", "graphical models", "SLAM", "inference", "sum-product", "belief-propagation"]
44
desc = "Implements the Multimodal-iSAMv2 algorithm."
5-
version = "0.32.3"
5+
version = "0.33.0"
66

77
[deps]
88
ApproxManifoldProducts = "9bbbb610-88a1-53cd-9763-118ce10c1f89"

test/testCompareVariablesFactors.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ fg2 = deepcopy(fg)
4646
@test compareSimilarFactors(fg, fg2; skip=[:particleidx])
4747

4848
@test compareFactorGraphs(fg, fg)
49-
@test_broken compareFactorGraphs(fg, fg2; skip=[:particleidx; :varidx])
49+
@test compareFactorGraphs(fg, fg2; skip=[:particleidx; :varidx])
5050

5151
# easier error messages
5252
getSolverParams(fg).multiproc = false
@@ -113,7 +113,7 @@ sfg = buildSubgraph(fg, [:x0;:x1], 1) # distance=1 to include factors
113113
#FIXME JT - this doesn't make sense to pass, it is a subgraph so should it not rather be ⊂ [subset]?
114114
# compareDFG(fg1, fg2, by=⊂, skip=...)
115115
@test fg.sessionLabel == sfg.sessionLabel[1:length(fg.sessionLabel)]
116-
@test_broken compareFactorGraphs(fg, sfg, skip=[:labelDict;:addHistory;:logpath;:sessionLabel; :particleidx; :varidx])
116+
@test compareFactorGraphs(fg, sfg, skip=[:labelDict;:addHistory;:logpath;:sessionLabel; :particleidx; :varidx])
117117

118118
# drawGraph(sfg)
119119

0 commit comments

Comments
 (0)