remove approxConvCircular

Author: dehann

NEWS.md

@@ -23,8 +23,7 @@ The list below highlights major breaking changes, and please note that significa
 - Deprecate use of `getParametricMeasurement` and use `getMeasurementParametric` instead, and add `<:AbstractManifold` to API.
 - Deprecate use of `solveBinaryFactorParameteric`, instead use `solveFactorParameteric`.
 - Deprecating `approxConvBinary`, use `approxConvBelief` instead.
-- Deprecating `accumulateFactorChain`, use `approxConvBelief` instead.
-
+- Removing obsolete `approxConvCircular`, use `approxConvBelief` instead.
 
 # Major changes in v0.24
 

src/AdditionalUtils.jl

@@ -1,5 +1,4 @@
 
-export approxConvCircular
 
 """
     $SIGNATURES

src/Deprecated.jl

@@ -26,6 +26,49 @@ end
 ##==============================================================================
 
 
+
+# """
+#     $SIGNATURES
+
+# Build an approximate density `[Y|X,DX,.]=[X|Y,DX][DX|.]` as proposed by the conditional convolution.
+
+# Notes
+# - Assume both are on circular manifold, `manikde!(pts, (:Circular,))`
+# """
+# function approxConvCircular(pX::ManifoldKernelDensity, 
+#                             pDX::ManifoldKernelDensity; N::Int=100)
+#   #
+
+#   # building basic factor graph
+#   tfg = initfg()
+#   addVariable!(tfg, :s1, Sphere1)
+#   addVariable!(tfg, :s2, Sphere1)
+#   addFactor!(tfg, [:s1;:s2], Sphere1Sphere1(pDX), graphinit=false)
+#   initManual!(tfg,:s1, pX)
+
+#   # solve for outgoing proposal value
+#   approxConv(tfg,:s1s2f1,:s2)
+# end
+
+# function approxConvCircular(pX::ManifoldKernelDensity, 
+#                             pDX::SamplableBelief; N::Int=100)
+#   #
+#   pts = reshape(rand(pDX, N), 1, :)
+#   pC = manikde!(pts, Sphere1)
+#   approxConvCircular(pX, pC)
+# end
+
+
+# function approxConvCircular(pX::SamplableBelief, 
+#                             pDX::ManifoldKernelDensity; N::Int=100)
+#   #
+#     pts = reshape(rand(pX, N), 1, :)
+#   pC = manikde!(pts, Sphere1)
+#   approxConvCircular(pC, pDX)
+# end
+
+
+
 @deprecate printGraphSummary(dfg::AbstractDFG, logger=ConsoleLogger()) show(logger.stream, MIME("text/plain"), dfg)
 @deprecate printSummary(dfg::AbstractDFG, logger=ConsoleLogger()) show(logger.stream, MIME("text/plain"), dfg)
 

src/services/ApproxConv.jl

@@ -312,54 +312,6 @@ end
 
 
 
-## ==========================================================================================
-## DEPRECATE / REFACTOR BELOW
-## ==========================================================================================
-
-
-
-
-"""
-    $SIGNATURES
-
-Build an approximate density `[Y|X,DX,.]=[X|Y,DX][DX|.]` as proposed by the conditional convolution.
-
-Notes
-- Assume both are on circular manifold, `manikde!(pts, (:Circular,))`
-"""
-function approxConvCircular(pX::ManifoldKernelDensity, 
-                            pDX::ManifoldKernelDensity; N::Int=100)
-  #
-
-  # building basic factor graph
-  tfg = initfg()
-  addVariable!(tfg, :s1, Sphere1)
-  addVariable!(tfg, :s2, Sphere1)
-  addFactor!(tfg, [:s1;:s2], Sphere1Sphere1(pDX), graphinit=false)
-  initManual!(tfg,:s1, pX)
-
-  # solve for outgoing proposal value
-  approxConv(tfg,:s1s2f1,:s2)
-end
-
-function approxConvCircular(pX::ManifoldKernelDensity, 
-                            pDX::SamplableBelief; N::Int=100)
-  #
-  pts = reshape(rand(pDX, N), 1, :)
-  pC = manikde!(pts, Sphere1)
-  approxConvCircular(pX, pC)
-end
-
-
-function approxConvCircular(pX::SamplableBelief, 
-                            pDX::ManifoldKernelDensity; N::Int=100)
-  #
-    pts = reshape(rand(pX, N), 1, :)
-  pC = manikde!(pts, Sphere1)
-  approxConvCircular(pC, pDX)
-end
-
-
 
 
 #