Skip to content

use QR for linear subsolver in parametric RLM#1859

Merged
dehann merged 1 commit intodevelopfrom
enh/qr_linear_solver
May 5, 2025
Merged

use QR for linear subsolver in parametric RLM#1859
dehann merged 1 commit intodevelopfrom
enh/qr_linear_solver

Conversation

@Affie
Copy link
Member

@Affie Affie commented Apr 29, 2025

No description provided.

jacobian_tangent_basis = DefaultOrthogonalBasis(),
initial_residual_values,
initial_jacobian_f,
linear_subsolver!,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mateuszbaran, can you please help me with how to use a custom linear_subsolver! in LevenbergMarquardt!. I couldn't quite figure out where to pass it in. QR is more numerically stable for SLAM problems so would like to try it out. Also note, ldiv! has an issue with sparse arrays but is fixed in julia 1.12.
"MethodError: no method matching ldiv!(::SparseArrays.CHOLMOD.Factor{Float64, Int64}, ::Vector{Float64})"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might also be wrong here with using LevenbergMarquardt! directly?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I forgot to put the subsolver as a keyword argument in the LevenbergMarquardt! function. I will add it tomorrow.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manopt 0.5.14 (just tagged) has the keyword argument. Let me know if you encounter any further issues.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dehann dehann marked this pull request as ready for review May 5, 2025 09:27
@dehann dehann merged commit 72dbca3 into develop May 5, 2025
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants