fast-forward keep solve changes (first use is extracting DERelative odes)#1878
Merged
fast-forward keep solve changes (first use is extracting DERelative odes)#1878
Conversation
dehann
changed the title
Member
Author
|
Hi @Affie , going to merge here. I tested on a local twig branch for conflicts [w liegroups branch] -- there was one small conflict that is easy to fix. The conflict was a simple delete "where T" portion of a change you did somewhere, and keeping the new function argument |
Member
|
If I’m not mistaken. The test failure has something to do with prior mixtures that broke with one of the recent DFG updates. So would agree that it’s unrelated to this pr. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mei-cheung , here is the stuff you need. Will be merging now