Skip to content

Conversation

el-oso
Copy link

@el-oso el-oso commented Jul 26, 2025

Attempt to make it trim compatible. I am not sure if I am missing something.
Assumed this is a draft PR

@chriselrod
Copy link
Member

It's hard to evaluate such a large diff.
Note the .JuliaFormatter.toml in the base repo seems to be ignored by however you're formatting.

But I may hand over the reigns completely here, so whatever new governance can decide on different formatting policies. If so, they should still do it in two steps: one PR is formatting only, the other can be separate changes.

@el-oso
Copy link
Author

el-oso commented Jul 26, 2025

You are right, forgot to use JuliaFormatter .
I am testing Runic.
The diff is basically that I remove the @evals and made @generated functions instead.
I also commented a lot of stuff because I am not sure what is the rationale behind it.

Copy link

codecov bot commented Jul 31, 2025

Codecov Report

❌ Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.48%. Comparing base (10e48a2) to head (f571858).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/x86.jl 0.00% 25 Missing ⚠️
src/CPUSummary.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #30       +/-   ##
==========================================
- Coverage   16.74%   0.48%   -16.27%     
==========================================
  Files           5       4        -1     
  Lines         209     208        -1     
==========================================
- Hits           35       1       -34     
- Misses        174     207       +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants