Reverting removal of equality checks for ==; apparently they are unused, even though this is not caught in CodeCov.

Author: chriselrod

src/constructors.jl

@@ -103,6 +103,8 @@ end
 function check_tile(arg)
     a1 = (arg.args[1])::Symbol
     a1 === :tile || return nothing
+    tup = arg.args[2]
+    @assert length(tup.args) == 2
     U = convert(Int8, tup.args[1])
     T = convert(Int8, tup.args[2])
     U, T

src/operations.jl

@@ -36,10 +36,10 @@ Base.:(==)(x::ArrayReference, y::ArrayReference) = isequal(x, y)
 Base.:(==)(x::ArrayReferenceMeta, y::ArrayReferenceMeta) = isequal(x.ref, y.ref) && x.ptr === y.ptr
 
 # Errors preferable than silently working?
-# Base.:(==)(x::ArrayReference, y::ArrayReferenceMeta) = x == y.ref
-# Base.:(==)(x::ArrayReferenceMeta, y::ArrayReference) = x.ref == y
-# Base.:(==)(x::ArrayReference, y) = false
-# Base.:(==)(x::ArrayReferenceMeta, y) = false
+Base.:(==)(x::ArrayReference, y::ArrayReferenceMeta) = x == y.ref
+Base.:(==)(x::ArrayReferenceMeta, y::ArrayReference) = x.ref == y
+Base.:(==)(x::ArrayReference, y) = false
+Base.:(==)(x::ArrayReferenceMeta, y) = false
 
 @enum OperationType begin
     constant

test/gemm.jl

@@ -174,6 +174,25 @@
         end
     end
 
+    function AmulB2x2avx!(C, A, B)
+        @avx tile=(2,2) for m ∈ 1:size(A,1), n ∈ 1:size(B,2)
+            ΔCₘₙ = zero(eltype(C))
+            for k ∈ 1:size(A,2)
+                ΔCₘₙ += A[m,k] * B[k,n]
+            end
+            C[m,n] = ΔCₘₙ
+        end
+    end
+    function AmulB2x2_avx!(C, A, B)
+        @_avx tile=(2,2) for m ∈ 1:size(A,1), n ∈ 1:size(B,2)
+            ΔCₘₙ = zero(eltype(C))
+            for k ∈ 1:size(A,2)
+                ΔCₘₙ += A[m,k] * B[k,n]
+            end
+            C[m,n] = ΔCₘₙ
+        end
+    end
+
     # function AtmulB!(C, A, B)
     #     for j ∈ 1:size(C,2), i ∈ 1:size(C,1)
     #         Cᵢⱼ = zero(eltype(C))
@@ -532,6 +551,10 @@
             @test C ≈ C2
             AmuladdBavx!(C, At', B, -2)
             @test C ≈ -C2
+            fill!(C, 9999.999); AmulB2x2avx!(C, A, B);
+            @test C ≈ C2
+            fill!(C, 9999.999); AmulB2x2avx!(C, At', B);
+            @test C ≈ C2
             fill!(C, 9999.999); AtmulBavx1!(C, At, B)
             @test C ≈ C2
             fill!(C, 9999.999); AtmulBavx1!(C, A', B)
@@ -570,6 +593,10 @@
             @test C ≈ C2
             AmuladdB_avx!(C, At', B, -2)
             @test C ≈ -C2
+            fill!(C, 9999.999); AmulB2x2_avx!(C, A, B);
+            @test C ≈ C2
+            fill!(C, 9999.999); AmulB2x2_avx!(C, At', B);
+            @test C ≈ C2
             fill!(C, 9999.999); AtmulB_avx1!(C, At, B)
             @test C ≈ C2
             fill!(C, 9999.999); AtmulB_avx1!(C, A', B)
@@ -604,6 +631,10 @@
             @test Cs ≈ C2
             AmuladdBavx!(Cs, Ats', Bs, -2)
             @test Cs ≈ -C2
+            fill!(Cs, 9999.999); AmulB2x2avx!(Cs, As, Bs)
+            @test Cs ≈ C2
+            fill!(Cs, 9999.999); AmulB2x2avx!(Cs, Ats', Bs)
+            @test Cs ≈ C2
             fill!(Cs, 9999.999); AtmulBavx1!(Cs, Ats, Bs)
             @test Cs ≈ C2
             fill!(Cs, 9999.999); AtmulBavx1!(Cs, As', Bs)
@@ -642,6 +673,10 @@
             @test Cs ≈ C2
             AmuladdB_avx!(Cs, Ats', Bs, -2)
             @test Cs ≈ -C2
+            fill!(Cs, 9999.999); AmulB2x2_avx!(Cs, As, Bs)
+            @test Cs ≈ C2
+            fill!(Cs, 9999.999); AmulB2x2_avx!(Cs, Ats', Bs)
+            @test Cs ≈ C2
             fill!(Cs, 9999.999); AtmulB_avx1!(Cs, Ats, Bs)
             @test Cs ≈ C2
             fill!(Cs, 9999.999); AtmulB_avx1!(Cs, As', Bs)