Skip to content

Removed unused CPUSummary summary call #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Removed unused CPUSummary summary call #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
90f2f31
Removed unused `CPUSummary` summary call
RomeoV Jul 26, 2025
5b1dfdf
Update CI.yml
ChrisRackauckas Jul 29, 2025
7e81e50
Update src/closure.jl
ChrisRackauckas Jul 30, 2025
c804c40
Update src/closure.jl
ChrisRackauckas Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/CI.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,9 @@ jobs:
fail-fast: false
matrix:
version:
- '1.6'
- 'lts'
- '1'
- 'pre'
os:
- ubuntu-latest
arch:
Expand Down
2 changes: 0 additions & 2 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ version = "0.7.18"
[deps]
ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"
BitTwiddlingConvenienceFunctions = "62783981-4cbd-42fc-bca8-16325de8dc4b"
CPUSummary = "2a0fbf3d-bb9c-48f3-b0a9-814d99fd7ab9"
IfElse = "615f187c-cbe4-4ef1-ba3b-2fcf58d6d173"
ManualMemory = "d125e4d3-2237-4719-b19c-fa641b8a4667"
PolyesterWeave = "1d0040c9-8b98-4ee7-8388-3f51789ca0ad"
Expand All @@ -18,7 +17,6 @@ ThreadingUtilities = "8290d209-cae3-49c0-8002-c8c24d57dab5"
[compat]
ArrayInterface = "7"
BitTwiddlingConvenienceFunctions = "0.1"
CPUSummary = "0.1.2 - 0.1.8, 0.1.11, 0.2.1"
IfElse = "0.1"
ManualMemory = "0.1.3"
PolyesterWeave = "0.1.8, 0.2"
Expand Down
1 change: 0 additions & 1 deletion src/Polyester.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ using PolyesterWeave:
UnsignedIteratorEarlyStop,
assume,
disable_polyester_threads
using CPUSummary: num_cores

export batch, @batch, disable_polyester_threads

Expand Down
2 changes: 1 addition & 1 deletion src/closure.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,7 +348,7 @@ function enclose(exorig::Expr, minbatchsize, per, threadlocal, reduction, stride
# typexpr_incomplete is missing `funcs`
# outerloop = Symbol("##outer##")
num_thread_expr::Union{Symbol,Expr} = if per === :core
Expr(:call, min, Symbol("##NUM#THREADS##"), Expr(:call, num_cores))
Expr(:call, min, Symbol("##NUM#THREADS##"), Expr(:call, Static.StaticInt{Threads.nthreads()}()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will be your unstable, right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be unstable but it's in an expression build, so it would just slap into a generated function. The real issue is that it's not pure 😅 but I'm just trying to force it to use the loopvec stuff as is

else
Symbol("##NUM#THREADS##")
end
Expand Down
Loading