Skip to content

Fix slicing of PtrArrays #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
efaulhaber merged 5 commits into from
Aug 19, 2025
Merged

Fix slicing of PtrArrays #51

efaulhaber merged 5 commits into from
Aug 19, 2025

Conversation

@efaulhaber
Copy link
Collaborator

@efaulhaber efaulhaber commented May 23, 2025

@efaulhaber efaulhaber closed this May 23, 2025
@efaulhaber efaulhaber reopened this May 23, 2025
@efaulhaber efaulhaber mentioned this pull request May 23, 2025
Closed
@efaulhaber
Copy link
Collaborator Author

efaulhaber commented May 23, 2025

@oscardssmith are you maintainer here too?

@oscardssmith
Copy link
Member

oscardssmith commented May 23, 2025

reluctantly, yes.

@efaulhaber
Copy link
Collaborator Author

efaulhaber commented Jun 30, 2025

I took a different approach now, essentially just throwing away the second index when indexing into a PtrVector. This doesn't break the other tests. Now all tests passing on main also pass with this PR locally.

@efaulhaber
Copy link
Collaborator Author

efaulhaber commented Jul 1, 2025

@oscardssmith could you please approve the CI?

@efaulhaber
Copy link
Collaborator Author

efaulhaber commented Jul 2, 2025

These CI fails look unrelated to my changes. I had to comment out this test to even make the tests run locally even on main.

@svchb svchb mentioned this pull request Jul 3, 2025
Merged
@efaulhaber
Copy link
Collaborator Author

efaulhaber commented Jul 14, 2025 •
edited
Loading

Now all errors are unrelated to my changes and the 1.6 version passes.

@efaulhaber
Copy link
Collaborator Author

efaulhaber commented Jul 16, 2025

@oscardssmith could you please approve CI here? Now with the CI fix merged.

@efaulhaber
Copy link
Collaborator Author

efaulhaber commented Jul 16, 2025

@oscardssmith Ready for review. The segfaults are unrelated and also happening in the latest CI run on main. The tests I added are wrapped inside GC.@preserve.

@efaulhaber
Copy link
Collaborator Author

efaulhaber commented Jul 21, 2025

bump

@efaulhaber
Copy link
Collaborator Author

efaulhaber commented Aug 12, 2025

@ranocha do you maybe have permissions to review/merge this? It might also cause problems with Trixi.jl.

@efaulhaber
Copy link
Collaborator Author

efaulhaber commented Aug 19, 2025

Merging now since no one seems to care enough to review this.

@efaulhaber efaulhaber merged commit aa91578 into JuliaSIMD:main Aug 19, 2025
9 of 11 checks passed
@efaulhaber efaulhaber deleted the fix-slicing branch August 19, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Slicing doesn't work with PtrArray

2 participants

@efaulhaber @oscardssmith