[WIP] Transition to package extensions#231
Draft
kiranshila wants to merge 2 commits intoJuliaSmoothOptimizers:mainfrom
Draft
[WIP] Transition to package extensions#231kiranshila wants to merge 2 commits intoJuliaSmoothOptimizers:mainfrom
kiranshila wants to merge 2 commits intoJuliaSmoothOptimizers:mainfrom
Conversation
Contributor
Author
|
Actually, I think this is way harder than I expected because of all the new data types. It seems like this might need some serious restructuring to fit into the package extension style. |
Member
|
Hi @kiranshila ! Thanks for working on this. Droping Julia version before 1.9 is a big decision though that I would prefer to delay for the moment if that's ok for you?
Do you have any link related to this? |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Julia 1.9, the recommended way to have optional dependencies and additional code that adds support for those optional dependencies is Package Extensions. This is a WIP PR to reorganize ADNLPModels to support them.
There are several benefits. First, the ability to precompile the extensions decreases the TTFx of code using the extensions, which is always good. Second, we can specify compat of the extensions' dependencies. This is really useful as AD backends like Enzyme are a little unstable and benefit from explicit, tagged versions.
Current Blockers
Additional Edits
I took the liberty of also removing the test
Project.tomlas current best practice is to define all the dependencies (including test deps) in the top level toml file and useextrasandtargets.