Fix TrunkSolver for quasi-Newton models #354
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the solver is initialized with a model that is not a quasi-Newton model, applying it to a quasi-Newton model with the same dimensions later fails. This change always allocates a vector inside the solver to store the previous gradient.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes TrunkSolver reuse when switching from a non–quasi-Newton model to a QuasiNewtonModel of the same dimension by ensuring the “previous gradient” workspace is always allocated.
Changes:
- Always allocate
gn(previous-gradient storage) inTrunkSolverregardless of the initial model type. - Remove the
reset!assertion that prevented reusing a solver instance across quasi-Newton vs non–quasi-Newton models.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
|
Contributor
|
Contributor
|
Member
Author
|
I may not merge this as I would like to manage quasi-Newton updates in the callback instead of in the solver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the solver is initialized with a model that is not a quasi-Newton model, applying it to a quasi-Newton model with the same dimensions later fails at line 240.
This change always allocates a vector inside the solver to store the previous gradient.