Fix/update subsolver api docs #149
Merged
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d API and add note on allowed subsolvers and tolerances (fixes JuliaSmoothOptimizers#145)
…type => new subsolver=:symbol)
…subsolver = :symbol)
…-squares variants
…attern with example
… only); docs: minor copy edits
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
Co-authored-by: Tangi Migot <[email protected]>
|
@tmigot please see the checks below. |
tmigot
approved these changes
Oct 20, 2025
|
Ouch I merged too fast. The code is not running. @arnavk23 please test the code before making the PR |
|
If you want to see the error: https://jso-preview.netlify.app/previews/pr203/tutorials/introduction-to-jsosolvers/ |
|
I was also surprised this was defined in JSOSolvers 0.11 |
arnavk23
added a commit
to arnavk23/JSOTutorials.jl
that referenced
this pull request
Oct 21, 2025
* docs(advanced-jsosolvers): update TRUNK subsolver usage to new keyword API and add note on allowed subsolvers and tolerances (fixes JuliaSmoothOptimizers#145) * docs(advanced-jsosolvers): add concise migration note (old subsolver_type => new subsolver=:symbol) * docs(intro): add migration note for subsolver API (subsolver_type => subsolver = :symbol) * docs(intro): show how to list allowed subsolvers for trunk/tron least-squares variants * docs(intro): add example of trunk with explicit subsolver and tolerances * docs(advanced-jsosolvers): add explicit trunk call with subsolver and tolerances * docs(advanced-jsosolvers): mention TRON uses same subsolver keyword pattern with example * docs: copy edits and grammar fixes in advanced and intro tutorials * test: make tutorial checks robust (require index.jmd and Project.toml only); docs: minor copy edits * docs(advanced-jsosolvers): add link to Krylov.jl docs for subsolver algorithm details * Update tutorials/advanced-jsosolvers/index.jmd Co-authored-by: Tangi Migot <[email protected]> * Update tutorials/advanced-jsosolvers/index.jmd Co-authored-by: Tangi Migot <[email protected]> * Update tutorials/introduction-to-jsosolvers/index.jmd Co-authored-by: Tangi Migot <[email protected]> * Update runtests.jl * Update index.jmd * Update index.jmd * Update index.jmd --------- Co-authored-by: Tangi Migot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tutorial
Updates to tutorial