-
Notifications
You must be signed in to change notification settings - Fork 8
Fix : Link checker #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tmigot
merged 15 commits into
JuliaSmoothOptimizers:main
from
arnavk23:fix/link-checker
Oct 25, 2025
Merged
Fix : Link checker #208
tmigot
merged 15 commits into
JuliaSmoothOptimizers:main
from
arnavk23:fix/link-checker
Oct 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed all the "excitement," "buzzing," and overselling language Simplified the title (no exclamation marks) Made it a short, factual announcement about Abel's podcast appearance Used a simple bulleted list to summarize what Abel discussed Direct link to the show notes for full details Removed all the celebratory/marketing-style sections
with: Metadata: title + rss_description Brief announcement paragraph Links to publisher page and DOI (as proper markdown links) One-sentence description of GPMR Reference line with DOI link
|
@tmigot please review. |
|
Well, I'd rather try to fix the links than silent the CI. I can live with this failing for now 😀 |
…ptimizers#198) Bumps [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) from 1.1.0 to 2.0.2. - [Release notes](https://github.com/lycheeverse/lychee-action/releases) - [Commits](lycheeverse/lychee-action@v1.1.0...v2.0.2) --- updated-dependencies: - dependency-name: lycheeverse/lychee-action dependency-version: 2.0.2 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…uliaSmoothOptimizers#204) Co-authored-by: JSOTutorials bot <[email protected]>
…uliaSmoothOptimizers#203) Co-authored-by: JSOTutorials bot <[email protected]>
…uliaSmoothOptimizers#205) Co-authored-by: JSOTutorials bot <[email protected]>
…uliaSmoothOptimizers#206) Co-authored-by: JSOTutorials bot <[email protected]>
…03/404 (abelsiqueira assets, gerad preprints, dx.doi -> doi.org, epubs.siam -> doi.org)
_data/references.json _data/bibtex/articles2019.bib _data/bibtex/articles2020.bib tutorials/index.md
360b284 to
7b9683b
Compare
|
@tmigot Sorry for misunderstanding, I have changes the old links. |
tmigot
approved these changes
Oct 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @arnavk23 !
|
Fix some of the links, related to #207 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited LinkChecker.yml on branch fix/link-checker to add excludes for a set of external hosts that were producing forbidden/404 noise:
Added excludes for:
Kept the existing excludes (gstatic, doi.org, PACKAGE.jl).
Lychee was failing on external hosts that either block crawlers (403) or have removed resources (404). Those cause the action to exit non-zero even though the repository content hasn't changed.
Excluding these domains prevents the workflow from failing due to external site behavior while still checking the rest of the site.
This is a pragmatic fix to unblock CI quickly. Longer-term we can:
Audit and fix broken links in the content (recommended for persistent 404s), or
Maintain a curated list of excluded domains (if some are known to be unreliable).