TRICG & TRIMR: support warm-start with ldiv=true #1043
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
To clarify, this is ready for review despite me having switched it to "draft." I did that just because it shouldn't be merged until I make commensurate changes to |
timholy
force-pushed
the
teh/tricg_warmstart
branch
from
d2ebcc8 to
f5ea9af
Compare
This addresses some potential inconsistencies in `tricg` and `trimr` in the case `ldiv=true`: - docs: fixes the statement about the relationship between `E`/`F` and `M`/`N` - docs: describes the residual-norm in terms of `E`/`F` rather than `M`/`N` (only the former are unambiguous, given the problem statement) - adds support for warm-starting when `ldiv=true` for arbitrary `M`/`N`
timholy
force-pushed
the
teh/tricg_warmstart
branch
from
f5ea9af to
4683dad
Compare
This was referenced Dec 4, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1043 +/- ##
==========================================
+ Coverage 94.68% 97.64% +2.96%
==========================================
Files 45 49 +4
Lines 8027 9481 +1454
==========================================
+ Hits 7600 9258 +1658
+ Misses 427 223 -204 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some potential inconsistencies in
tricgandtrimrinthe case
ldiv=true:E/FandM/NE/Frather thanM/N(only the former are unambiguous, given the problem statement)ldiv=truefor arbitraryM/NNOTE: this is a WIP as
trimrhas not yet been modified. Once we settle on thetricgchanges, I'll port the same changes totrimr.