-
Notifications
You must be signed in to change notification settings - Fork 18
Add DistributedArrays #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Removed introductory comments about distributed-array helpers tests.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 20.70% 23.32% +2.61%
==========================================
Files 6 8 +2
Lines 792 819 +27
==========================================
+ Hits 164 191 +27
Misses 628 628 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Helpers for support of DistributedArrays/DArray without adding a hard dependency.
Add DistributedArrays to Project.toml
It is a hard dependency with what you did and we don't want that.
It should be a package extension.
Add mumps_test_distributed_helpers.jl - tests skip when DistributedArrays is not available
It makes no sense, it could never happen in Julia that a package that is dependency is not available.
Probably a sentence generated by a LLM...
Removed check for DistributedArrays package before running tests.
…he distributed helper test
|
@amontoison everything done here. |
Added DistributedArrays to Project.toml
Fixes #91