Skip to content

Conversation

@arnavk23
Copy link
Contributor

@arnavk23 arnavk23 commented Oct 30, 2025

Added DistributedArrays to Project.toml
Fixes #91

@arnavk23 arnavk23 changed the title Add optional DistributedArrays helpers and tests Add DistributedArrays helpers and tests Oct 30, 2025
@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

❌ Patch coverage is 45.00000% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 23.32%. Comparing base (d314826) to head (ca39b42).
⚠️ Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
src/distributed.jl 45.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   20.70%   23.32%   +2.61%     
==========================================
  Files           6        8       +2     
  Lines         792      819      +27     
==========================================
+ Hits          164      191      +27     
  Misses        628      628              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@amontoison amontoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helpers for support of DistributedArrays/DArray without adding a hard dependency.
Add DistributedArrays to Project.toml

It is a hard dependency with what you did and we don't want that.
It should be a package extension.

Add mumps_test_distributed_helpers.jl - tests skip when DistributedArrays is not available

It makes no sense, it could never happen in Julia that a package that is dependency is not available.
Probably a sentence generated by a LLM...

Removed check for DistributedArrays package before running tests.
@arnavk23 arnavk23 requested a review from amontoison November 1, 2025 05:12
@arnavk23 arnavk23 changed the title Add DistributedArrays helpers and tests Add DistributedArrays Nov 1, 2025
@arnavk23 arnavk23 requested a review from amontoison November 1, 2025 08:31
@arnavk23
Copy link
Contributor Author

arnavk23 commented Feb 6, 2026

@amontoison everything done here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support distributed matrices and vectors

2 participants