Try to fix the performances of the split API#538
Draft
amontoison wants to merge 1 commit intoam/sparsefrom
Draft
Try to fix the performances of the split API#538amontoison wants to merge 1 commit intoam/sparsefrom
amontoison wants to merge 1 commit intoam/sparsefrom
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #511, #516, #384
I would like to check if many packages are broken with these modifications in JSO.
It is already a few months that we have issues with performances because of the linear / nonlinear API.
For a long time we only supported the "normal" API, I still think that it should be the base API that the user should implement.
I suggest to only implement linear / nonlinear API as optional routines.
The only optimization solver that can exploit the split API is KNITRO and it is quite hard to exploit it in other solvers, like Ipopt, MadNLP or Uno.
To the best of my knowledge, we also don't exploit it in optimization solvers implemented in JSO packages (except if we call KNITRO).
Update: Argh, almost all packages are impacted...