Skip to content

Add an option test_counters #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amontoison merged 2 commits into from
Aug 8, 2025
Merged

Add an option test_counters #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97f760a
Add an option test_counters
amontoison Aug 8, 2025
16ec850
Add an option test_counters
amontoison Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: actions/cache@v1
- uses: actions/cache@v4
env:
cache-name: cache-artifacts
with:
Expand Down
11 changes: 6 additions & 5 deletions src/nlp/consistency.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,16 +21,17 @@ function consistent_nlps(
test_slack = true,
test_qn = true,
test_derivative = true,
test_counters = true,
rtol = 1.0e-8,
)
consistent_counters(nlps, linear_api = linear_api, reimplemented = reimplemented)
test_counters && consistent_counters(nlps, linear_api = linear_api, reimplemented = reimplemented)
test_meta && consistent_meta(nlps, rtol = rtol)
consistent_functions(nlps, linear_api = linear_api, rtol = rtol, exclude = exclude)
consistent_counters(nlps, linear_api = linear_api, reimplemented = reimplemented)
test_counters && consistent_counters(nlps, linear_api = linear_api, reimplemented = reimplemented)
for nlp in nlps
reset!(nlp)
end
consistent_counters(nlps, linear_api = linear_api, reimplemented = reimplemented)
test_counters && consistent_counters(nlps, linear_api = linear_api, reimplemented = reimplemented)
if test_derivative
for nlp in nlps
@test length(gradient_check(nlp)) == 0
Expand All @@ -51,7 +52,7 @@ function consistent_nlps(
linear_api = linear_api,
exclude = [hess, hess_coord, hprod, jth_hess, jth_hess_coord, jth_hprod, ghjvprod] ∪ exclude,
)
consistent_counters([nlps; qnmodels], linear_api = linear_api, reimplemented = reimplemented)
test_counters && consistent_counters([nlps; qnmodels], linear_api = linear_api, reimplemented = reimplemented)
end

if test_slack && has_inequalities(nlps[1])
Expand All @@ -62,7 +63,7 @@ function consistent_nlps(
linear_api = linear_api,
exclude = [jth_hess, jth_hess_coord, jth_hprod] ∪ exclude,
)
consistent_counters(slack_nlps, linear_api = linear_api, reimplemented = reimplemented)
test_counters && consistent_counters(slack_nlps, linear_api = linear_api, reimplemented = reimplemented)
end
end

Expand Down
2 changes: 1 addition & 1 deletion src/nlp/coord-memory.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export coord_memory_nlp

"""
coord_memory_nlp(nlp; exclude = [])
coord_memory_nlp(nlp; linear_api = false, exclude = [])

Check that the allocated memory for in place coord methods is
sufficiently smaller than their allocating counter parts.
Expand Down
13 changes: 7 additions & 6 deletions src/nls/consistency.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,13 @@ function consistent_nlss(
linear_api = false,
test_slack = true,
test_ff = true,
test_counters = true,
)
consistent_nls_counters(nlss)
consistent_counters(nlss, linear_api = linear_api)
test_counters && consistent_counters(nlss, linear_api = linear_api)
consistent_nls_functions(nlss, exclude = exclude)
consistent_nls_counters(nlss)
consistent_counters(nlss, linear_api = linear_api)
test_counters && consistent_counters(nlss, linear_api = linear_api)
for nls in nlss
reset!(nls)
end
Expand All @@ -35,8 +36,8 @@ function consistent_nlss(
reset!.(nlss)
slack_nlss = SlackNLSModel.(nlss)
consistent_nls_functions(slack_nlss, exclude = exclude)
consistent_nls_counters(slack_nlss)
consistent_counters(slack_nlss, linear_api = linear_api)
test_counters && consistent_nls_counters(slack_nlss)
test_counters && consistent_counters(slack_nlss, linear_api = linear_api)
consistent_functions(
slack_nlss,
linear_api = linear_api,
Expand All @@ -48,8 +49,8 @@ function consistent_nlss(
reset!.(nlss)
ff_nlss = FeasibilityFormNLS.(nlss)
consistent_nls_functions(ff_nlss, exclude = exclude)
consistent_nls_counters(ff_nlss)
consistent_counters(ff_nlss, linear_api = false)
test_counters && consistent_nls_counters(ff_nlss)
test_counters && consistent_counters(ff_nlss, linear_api = false)
consistent_functions(
ff_nlss,
linear_api = false,
Expand Down
Loading