Apply suggestions from code review

Author: tmigot

src/ADNLPProblems/auglag.jl

@@ -36,15 +36,15 @@ function auglag(; n::Int = default_nvar, type::Type{T} = Float64, kwargs...) whe
   for i = 1:n
     m = mod(i, 5)
     if m == 1
-      x0[i] = i <= 2 ? T(-2) : T(-1)
+      x0[i] = i <= 2 ? -2 : -1
     elseif m == 2
-      x0[i] = i <= 2 ? T(2) : T(-1)
+      x0[i] = i <= 2 ? 2 : -1
     elseif m == 3
-      x0[i] = T(2)
+      x0[i] = 2
     elseif m == 4
-      x0[i] = T(-1)
+      x0[i] = -1
     else
-      x0[i] = T(-1)
+      x0[i] = -1
     end
   end
 

src/ADNLPProblems/genbroydenb.jl

@@ -21,8 +21,7 @@ function genbroydenb(::Val{:nlp}; n::Int = default_nvar, type::Type{T} = Float64
     end
     return s
   end
-  x0 = Vector{T}(undef, n)
-  fill!(x0, -one(T))
+  x0 = fill(-one(T), n)
   return ADNLPModels.ADNLPModel(f, x0, name = "genbroydenb", minimize = true; kwargs...)
 end
 
@@ -39,13 +38,10 @@ function genbroydenb(::Val{:nls}; n::Int = default_nvar, type::Type{T} = Float64
         end
       end
       z = diag + neigh
-      r[i] = sign(z) * abs(z)^(p)
+      r[i] = abs(z)^(p)
     end
     return r
   end
-
-  x0 = Vector{T}(undef, n)
-  fill!(x0, -one(T))
-
+x0 = fill(-one(T), n)
   return ADNLPModels.ADNLSModel!(F!, x0, n, name = "genbroydenb-nls"; kwargs...)
 end

src/PureJuMP/nazareth.jl

@@ -10,11 +10,11 @@
 #   https://www.researchgate.net/publication/325314400_Sparse_Test_Problems_for_Unconstrained_Optimization
 export nazareth
 
-function nazareth(; n::Int = default_nvar, type::Type{T} = Float64) where {T}
+function nazareth(; n::Int = default_nvar)
   nh = div(n, 2)
 
   nlp = Model()
-  @variable(nlp, x[1:n], start = one(T) / T(n))
+  @variable(nlp, x[1:n], start = 1 / n)
 
   @objective(nlp, Min, sum((
     begin
@@ -40,6 +40,6 @@ function nazareth(; n::Int = default_nvar, type::Type{T} = Float64) where {T}
 
       (n + i - sumtrig)^2
     end
-  ) for i = 1:n) / T(n))
+  ) for i = 1:n) / n)
   return nlp
 end