Skip to content

Conversation

@arnavk23
Copy link
Contributor

@arnavk23 arnavk23 commented Nov 3, 2025

@arnavk23 arnavk23 requested a review from tmigot November 5, 2025 05:35
@arnavk23 arnavk23 requested a review from tmigot November 5, 2025 16:13
@arnavk23 arnavk23 requested a review from tmigot November 6, 2025 18:20
Copy link
Member

@tmigot tmigot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arnavk23 can you please pay more attention to your PR when you ask for the review?
I am making the same comments and the problem code does not match the screenshot you gave. There is obviously an error in the book as both sums have the same indices so please explain what you chose

@arnavk23 arnavk23 requested a review from tmigot November 9, 2025 07:23
@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 71.25000% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 54.53%. Comparing base (2ada450) to head (3d76a65).
⚠️ Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
src/PureJuMP/boundary.jl 0.00% 7 Missing ⚠️
src/PureJuMP/variational.jl 0.00% 7 Missing ⚠️
src/Meta/variational.jl 28.57% 5 Missing ⚠️
src/Meta/boundary.jl 42.85% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #385       +/-   ##
===========================================
- Coverage   99.80%   54.53%   -45.28%     
===========================================
  Files        1084     1129       +45     
  Lines       12319    13277      +958     
===========================================
- Hits        12295     7240     -5055     
- Misses         24     6037     +6013     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arnavk23
Copy link
Contributor Author

@tmigot Thank you for all your help. I found it very difficult to implement variational and thus ended up making a lot of mistakes (often the same one again and again :) ). I apologize if in the whole process I ever troubled you. I'll communicate better in the future if I face any such problem ( I just thought to tackle this head on this time). But all in all, thanks for being this patient with me and helping me learn.

@tmigot tmigot merged commit 79d19e4 into JuliaSmoothOptimizers:main Nov 13, 2025
15 of 18 checks passed
@arnavk23 arnavk23 deleted the luksan/add-problems-5-12 branch November 13, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants