Skip to content

Commit 759e945

Browse files
dpogeoffroyleconte
authored andcommitted
🤖 Format .jl files
1 parent 18d6c2b commit 759e945

File tree

3 files changed

+50
-34
lines changed

3 files changed

+50
-34
lines changed

src/linalg_utils.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@ function SparseArrays.nnz(M::Symmetric{T, <:DenseMatrix{T}}) where {T}
77
n = size(M, 1)
88
return n * (n + 1) / 2
99
end
10-
SparseArrays.nnz(M::Symmetric{T, <:AbstractSparseMatrix{T}}) where {T} = nnz(M.data)
10+
SparseArrays.nnz(M::Symmetric{T, <:AbstractSparseMatrix{T}}) where {T} = nnz(M.data)

src/qpmodel.jl

Lines changed: 38 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,18 @@ end
1414

1515
isdense(data::QPData{T, S, M1, M2}) where {T, S, M1, M2} = M1 <: DenseMatrix || M2 <: DenseMatrix
1616

17-
function Base.convert(::Type{QPData{T, S, MCOO, MCOO}}, data::QPData{T, S, M1, M2}) where {T, S, M1 <: AbstractMatrix, M2 <: AbstractMatrix, MCOO <: SparseMatrixCOO{T}}
17+
function Base.convert(
18+
::Type{QPData{T, S, MCOO, MCOO}},
19+
data::QPData{T, S, M1, M2},
20+
) where {T, S, M1 <: AbstractMatrix, M2 <: AbstractMatrix, MCOO <: SparseMatrixCOO{T}}
1821
HCOO = (M1 <: SparseMatrixCOO) ? data.H : SparseMatrixCOO(data.H)
1922
ACOO = (M2 <: SparseMatrixCOO) ? data.A : SparseMatrixCOO(data.A)
2023
return QPData(data.c0, data.c, HCOO, ACOO)
2124
end
22-
Base.convert(::Type{QPData{T, S, MCOO, MCOO}}, data::QPData{T, S, M1, M2}) where {T, S, M1 <: SparseMatrixCOO, M2 <: SparseMatrixCOO, MCOO <: SparseMatrixCOO{T}} = data
25+
Base.convert(
26+
::Type{QPData{T, S, MCOO, MCOO}},
27+
data::QPData{T, S, M1, M2},
28+
) where {T, S, M1 <: SparseMatrixCOO, M2 <: SparseMatrixCOO, MCOO <: SparseMatrixCOO{T}} = data
2329

2430
abstract type AbstractQuadraticModel{T, S} <: AbstractNLPModel{T, S} end
2531

@@ -64,7 +70,10 @@ mutable struct QuadraticModel{T, S, M1, M2} <: AbstractQuadraticModel{T, S}
6470
data::QPData{T, S, M1, M2}
6571
end
6672

67-
function Base.convert(::Type{QuadraticModel{T, S, Mconv, Mconv}}, qm::QuadraticModel{T, S, M1, M2}) where {T, S, M1 <: AbstractMatrix, M2 <: AbstractMatrix, Mconv}
73+
function Base.convert(
74+
::Type{QuadraticModel{T, S, Mconv, Mconv}},
75+
qm::QuadraticModel{T, S, M1, M2},
76+
) where {T, S, M1 <: AbstractMatrix, M2 <: AbstractMatrix, Mconv}
6877
data_conv = convert(QPData{T, S, Mconv, Mconv}, qm.data)
6978
return QuadraticModel(qm.meta, qm.counters, data_conv)
7079
end
@@ -260,18 +269,18 @@ end
260269

261270
function fill_structure!(S::SparseMatrixCSC, rows, cols)
262271
count = 1
263-
@inbounds for col = 1 : size(S, 2), k = S.colptr[col] : (S.colptr[col+1]-1)
264-
rows[count] = S.rowval[k]
265-
cols[count] = col
266-
count += 1
272+
@inbounds for col = 1:size(S, 2), k = S.colptr[col]:(S.colptr[col + 1] - 1)
273+
rows[count] = S.rowval[k]
274+
cols[count] = col
275+
count += 1
267276
end
268277
end
269278

270279
function fill_coord!(S::SparseMatrixCSC, vals, obj_weight)
271280
count = 1
272-
@inbounds for col = 1 : size(S, 2), k = S.colptr[col] : (S.colptr[col+1]-1)
273-
vals[count] = obj_weight * S.nzval[k]
274-
count += 1
281+
@inbounds for col = 1:size(S, 2), k = S.colptr[col]:(S.colptr[col + 1] - 1)
282+
vals[count] = obj_weight * S.nzval[k]
283+
count += 1
275284
end
276285
end
277286

@@ -290,8 +299,8 @@ function NLPModels.hess_structure!(
290299
cols::AbstractVector{<:Integer},
291300
) where {T, S, M1 <: Matrix}
292301
count = 1
293-
for j=1:qp.meta.nvar
294-
for i=j:qp.meta.nvar
302+
for j = 1:(qp.meta.nvar)
303+
for i = j:(qp.meta.nvar)
295304
rows[count] = i
296305
cols[count] = j
297306
count += 1
@@ -330,9 +339,9 @@ function NLPModels.hess_coord!(
330339
) where {T, S, M1 <: Matrix}
331340
NLPModels.increment!(qp, :neval_hess)
332341
count = 1
333-
for j=1:qp.meta.nvar
334-
for i=j:qp.meta.nvar
335-
vals[count] = obj_weight * qp.data.H[i,j]
342+
for j = 1:(qp.meta.nvar)
343+
for i = j:(qp.meta.nvar)
344+
vals[count] = obj_weight * qp.data.H[i, j]
336345
count += 1
337346
end
338347
end
@@ -372,8 +381,8 @@ function NLPModels.jac_structure!(
372381
cols::AbstractVector{<:Integer},
373382
) where {T, S, M1, M2 <: Matrix}
374383
count = 1
375-
for j=1:qp.meta.nvar
376-
for i=1:qp.meta.ncon
384+
for j = 1:(qp.meta.nvar)
385+
for i = 1:(qp.meta.ncon)
377386
rows[count] = i
378387
cols[count] = j
379388
count += 1
@@ -385,8 +394,8 @@ end
385394
function NLPModels.jac_coord!(
386395
qp::QuadraticModel{T, S, M1, M2},
387396
x::AbstractVector,
388-
vals::AbstractVector
389-
) where {T, S, M1, M2 <: SparseMatrixCOO}
397+
vals::AbstractVector,
398+
) where {T, S, M1, M2 <: SparseMatrixCOO}
390399
NLPModels.increment!(qp, :neval_jac)
391400
vals .= qp.data.A.vals
392401
return vals
@@ -395,8 +404,8 @@ end
395404
function NLPModels.jac_coord!(
396405
qp::QuadraticModel{T, S, M1, M2},
397406
x::AbstractVector,
398-
vals::AbstractVector
399-
) where {T, S, M1, M2 <: SparseMatrixCSC}
407+
vals::AbstractVector,
408+
) where {T, S, M1, M2 <: SparseMatrixCSC}
400409
NLPModels.increment!(qp, :neval_jac)
401410
fill_coord!(qp.data.A, vals, one(T))
402411
return vals
@@ -405,12 +414,12 @@ end
405414
function NLPModels.jac_coord!(
406415
qp::QuadraticModel{T, S, M1, M2},
407416
x::AbstractVector,
408-
vals::AbstractVector
409-
) where {T, S, M1, M2 <: Matrix}
417+
vals::AbstractVector,
418+
) where {T, S, M1, M2 <: Matrix}
410419
NLPModels.increment!(qp, :neval_jac)
411420
count = 1
412-
for j=1:qp.meta.nvar
413-
for i=1:qp.meta.ncon
421+
for j = 1:(qp.meta.nvar)
422+
for i = 1:(qp.meta.ncon)
414423
vals[count] = qp.data.A[i, j]
415424
count += 1
416425
end
@@ -538,7 +547,10 @@ function slackdata(data::QPData{T}, meta::NLPModelMeta{T}, ns::Int) where {T}
538547
)
539548
end
540549

541-
function NLPModelsModifiers.SlackModel(qp::AbstractQuadraticModel{T, S}, name = qp.meta.name * "-slack") where{T, S}
550+
function NLPModelsModifiers.SlackModel(
551+
qp::AbstractQuadraticModel{T, S},
552+
name = qp.meta.name * "-slack",
553+
) where {T, S}
542554
qp.meta.ncon == length(qp.meta.jfix) && return qp
543555
nfix = length(qp.meta.jfix)
544556
ns = qp.meta.ncon - nfix

test/runtests.jl

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,13 @@ using LinearAlgebra, Printf, SparseArrays, Test
33

44
# our packages
55
using ADNLPModels,
6-
LinearOperators, NLPModels, NLPModelsModifiers, NLPModelsTest, QPSReader, QuadraticModels, SparseMatricesCOO
6+
LinearOperators,
7+
NLPModels,
8+
NLPModelsModifiers,
9+
NLPModelsTest,
10+
QPSReader,
11+
QuadraticModels,
12+
SparseMatricesCOO
713

814
@testset "test utils" begin
915
A = rand(10, 10)
@@ -12,7 +18,7 @@ using ADNLPModels,
1218
@test nnz(Symmetric(A)) == 55
1319
v1, v2 = rand(10), rand(9)
1420
@test nnz(SymTridiagonal(v1, v2)) == 19
15-
Asp = sparse([1. 0. 0. ; 1. 0. 0. ; 0. 3. 2.])
21+
Asp = sparse([1.0 0.0 0.0; 1.0 0.0 0.0; 0.0 3.0 2.0])
1622
@test nnz(Symmetric(Asp, :L)) == 4
1723
end
1824

@@ -110,14 +116,12 @@ end
110116
c0 = 0.0,
111117
name = "QM1",
112118
)
113-
119+
114120
smdense = SlackModel(qpdense)
115121
testSM(smdense)
116122

117-
qpcoo = convert(
118-
QuadraticModel{T, Vector{T}, SparseMatrixCOO{T, Int}, SparseMatrixCOO{T, Int}},
119-
qpdense
120-
)
123+
qpcoo =
124+
convert(QuadraticModel{T, Vector{T}, SparseMatrixCOO{T, Int}, SparseMatrixCOO{T, Int}}, qpdense)
121125
@test typeof(qpcoo.data.H) <: SparseMatrixCOO
122126
@test typeof(qpcoo.data.A) <: SparseMatrixCOO
123127
end

0 commit comments

Comments
 (0)