Skip to content

Add preallocation for obj #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2025
Merged

Add preallocation for obj #142

merged 4 commits into from
May 14, 2025

Conversation

MaxenceGollier
Copy link
Contributor

dpo
dpo reviewed Feb 25, 2025
View reviewed changes
@MaxenceGollier @dpo
Update src/qpmodel.jl
2c80a96 
Co-authored-by: Dominique <[email protected]>
@dpo
Copy link
Member

dpo commented Apr 1, 2025

@MaxenceGollier Could you please rebase?

@amontoison
Copy link
Member

amontoison commented Apr 20, 2025 •
edited
Loading

@MaxenceGollier
I did a function a function coo_sym_dot in NLPModelsJuMP.jl a very long time ago (before the creation of SparseMatricesCOO.jl).
I think it what you need here and avoid the need to preallocate a additional vector.

@amontoison amontoison merged commit 3da8ae7 into JuliaSmoothOptimizers:main May 14, 2025
1 check passed
@amontoison amontoison mentioned this pull request May 16, 2025
Closed
2 tasks
@MaxenceGollier MaxenceGollier deleted the obj_allocs branch May 18, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpo dpo dpo left review comments

@amontoison amontoison amontoison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MaxenceGollier @dpo @amontoison