Skip to content

Fix the unit tests #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 18, 2025
Merged

Fix the unit tests #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32316ab
Fix the unit tests
amontoison May 18, 2025
23f5cf8
Test the linear API
amontoison May 18, 2025
0d408a1
Use pre-release instead of nightly in CI
amontoison May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@ jobs:
os: macos-latest
arch: arm64
allow_failure: false
- version: 'nightly'
- version: 'pre'
os: ubuntu-latest
arch: x64
allow_failure: true
- version: 'nightly'
- version: 'pre'
os: macos-latest
arch: x64
allow_failure: true
- version: 'nightly'
- version: 'pre'
os: windows-latest
arch: x64
allow_failure: true
Expand Down
3 changes: 2 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ QuadraticModelsQPSReaderExt = "QPSReader"
[compat]
LinearAlgebra = "1.10"
LinearOperators = "2.3"
NLPModels = "0.21.4"
NLPModels = "0.21.5"
NLPModelsModifiers = "0.7"
QPSReader = "0.2.1"
SolverCore = "0.3"
SparseArrays = "1.10"
SparseMatricesCOO = "0.2.3"
Expand Down
2 changes: 1 addition & 1 deletion test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
[compat]
ADNLPModels = "0.8"
LinearOperators = "2"
NLPModels = "0.21.4"
NLPModels = "0.21.5"
NLPModelsModifiers = "0.7"
NLPModelsTest = "0.10"
QPSReader = "0.2"
Expand Down
15 changes: 10 additions & 5 deletions test/test_allocations.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,28 +11,32 @@ end
@testset "allocs QPSData" begin
for problem in qp_problems_Matrix
nlp_qps = eval(Symbol(problem * "_QPSData"))()
test_only_zeros(test_allocs_nlpmodels(nlp_qps))
allocs = test_allocs_nlpmodels(nlp_qps; linear_api=true, exclude=[jac_op])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you create an issue connected to this? It doesn't seem normal.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I didn't opened an issue. It seems to appear around Julia 1.11.4 / 1.11.5.
I got a similar issue with Krylov.jl.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it is a LinearOperators problem?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be. I also suspect that FastClosures.jl.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create issues so we can track this? Thanks!

test_only_zeros(allocs)
end
end

@testset "allocs QP_dense" begin
for problem in qp_problems_Matrix
nlp_qm_dense = eval(Symbol(problem * "_QP_dense"))()
test_only_zeros(test_allocs_nlpmodels(nlp_qm_dense))
allocs = test_allocs_nlpmodels(nlp_qm_dense; linear_api=true, exclude=[jac_op])
test_only_zeros(allocs)
end
end

@testset "allocs COO QPSData" begin
for problem in qp_problems_COO
nlp_qps = eval(Symbol(problem * "_QPSData"))()
test_only_zeros(test_allocs_nlpmodels(nlp_qps))
allocs = test_allocs_nlpmodels(nlp_qps; linear_api=true, exclude=[jac_op])
test_only_zeros(allocs)
end
end

@testset "allocs COO QP" begin
for problem in qp_problems_COO
nlp_qm_dense = eval(Symbol(problem * "_QP"))()
test_only_zeros(test_allocs_nlpmodels(nlp_qm_dense))
allocs = test_allocs_nlpmodels(nlp_qm_dense; linear_api=true, exclude=[jac_op])
test_only_zeros(allocs)
end
end

Expand All @@ -41,7 +45,8 @@ end
nlp = eval(Symbol(problem))()
x = nlp.meta.x0
nlp_qm = QuadraticModel(nlp, x)
test_only_zeros(test_allocs_nlpmodels(nlp_qm))
allocs = test_allocs_nlpmodels(nlp_qm; linear_api=true, exclude=[jac_op])
test_only_zeros(allocs)
end
end
end
Loading