Skip to content

fix Julia v1.13 support#124

Merged
KristofferC merged 3 commits intoJuliaSparse:masterfrom
vtjnash:jn/ccall-bugfix
Nov 20, 2025
Merged

fix Julia v1.13 support#124
KristofferC merged 3 commits intoJuliaSparse:masterfrom
vtjnash:jn/ccall-bugfix

Conversation

@vtjnash
Copy link
Copy Markdown
Contributor

@vtjnash vtjnash commented Nov 19, 2025

Reverts the breaking part of the changes from #78, while keeping the
tweaks. This should be more compatible with future lazy library updates
to MKL_jll avoiding further future breakage, hopefully.

@vtjnash vtjnash changed the title fix Julia v1.13 support fix Julia v1.12 support Nov 19, 2025
Reverts the breaking part of the changes from JuliaSparse#78, while keeping the
tweaks. This should be more compatible with future lazy library updates
to MKL_jll avoiding further future breakage, hopefully.
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 19, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.31%. Comparing base (01de2fd) to head (d8f9815).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/Pardiso.jl 57.14% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   45.20%   45.31%   +0.11%     
==========================================
  Files           4        4              
  Lines         469      470       +1     
==========================================
+ Hits          212      213       +1     
  Misses        257      257              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vtjnash vtjnash changed the title fix Julia v1.12 support fix Julia v1.13 support Nov 19, 2025
@vtjnash
Copy link
Copy Markdown
Contributor Author

vtjnash commented Nov 19, 2025

Explicitly this is not a String and is explicitly expected to be untyped, please remove your commit before merging my PR

@vtjnash
Copy link
Copy Markdown
Contributor Author

vtjnash commented Nov 19, 2025

If you want to do this correctly and strongly-typed later, after this PR, it should just be import MKL_jll: libmkl_rt and delete all of the random LOCAL_MKL_FOUND and MKL_LOAD_FAILED and __init__ stuff that makes builds non-reproducible and potentially rather buggy (that stuff is supposed to be handled by the user with Artifact preferences, to ensure builds are (re)generated correctly for distribution.)

@KristofferC
Copy link
Copy Markdown
Member

What type is it then :).

And yes, the code here was written a long long time ago.

@KristofferC KristofferC merged commit f2ae3b4 into JuliaSparse:master Nov 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants