QR: handle xtype/dtype returned from LibSuiteSparse that don't match matrix element type #586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #586 +/- ##
==========================================
+ Coverage 84.03% 84.07% +0.04%
==========================================
Files 12 12
Lines 9183 9188 +5
==========================================
+ Hits 7717 7725 +8
+ Misses 1466 1463 -3 ☔ View full report in Codecov by Sentry. |
ViralBShah
pushed a commit
that referenced
this pull request
Feb 17, 2025
I fixed the same bug as #585, without realizing that it had already been done. It wasn't a complete waste of time, because the PR #586 left some cleanup to do: the lines ```julia LinearAlgebra.qr(A::SparseMatrixCSC{<:Union{Float16,Float32}}; tol=_default_tol(A)) = qr(convert(SparseMatrixCSC{Float64}, A); tol=tol) LinearAlgebra.qr(A::SparseMatrixCSC{<:Union{ComplexF16,ComplexF32}}; tol=_default_tol(A)) = qr(convert(SparseMatrixCSC{ComplexF64}, A); tol=tol) ``` would have prevented it from working if they actually worked! Luckily they don't, as the correct method is more specific and gets called, but it's still worth fixing. I also changed them to convert `Float16` to `Float32` instead of `Float64`, and the analogous change for complex numbers. I also fixed the error messages one gets. They were of the form "dtype=$(s.dtype) not supported", which in my case translated to saying that `Float64` wasn't supported when I tried calling it with `Float32`. `s.dtype` is the type that actually got computed, so it clearly is supported. I changed them to say "dtype=$(dtyp(Tv)) not supported".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LibSuiteSparsemethods called fromqr!might return structures withdtypethat doesn't match the element type of matrix to factorize. This occurs forTv=Float32and Julia>=1.11.Should fix #585