- 
                Notifications
    
You must be signed in to change notification settings  - Fork 64
 
          Solve with AdjointFactorization of Cholmod and Adjoint rhs
          #595
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          Codecov ReportAll modified and coverable lines are covered by tests ✅ 
 Additional details and impacted files@@           Coverage Diff           @@
##             main     #595   +/-   ##
=======================================
  Coverage   84.06%   84.06%           
=======================================
  Files          12       12           
  Lines        9191     9192    +1     
=======================================
+ Hits         7726     7727    +1     
  Misses       1465     1465           ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the swift solution! I wonder why the new method of (\) is not covered by the tests. 👀
Could this be backported to Julia 1.10, please?
          
 I'm not sure about that. @ViralBShah @KristofferC This was failing due to a "missing method". I guess this counts more like a "new feature" rather than "bugfix". @jonas-schulze If we decide against backporting, you could commit type piracy in your package and define this one method in a version-dependent branch...? I know it's not optimal, but I personally have used all my credits (if I ever had some) for arguing in favor of a semver-breaking action. 😅  | 
    
| 
           I think it is ok to backport it, but @KristofferC should be the person to ask.  | 
    
Fixes #594.