Skip to content

Conversation

@Keno
Copy link
Contributor

@Keno Keno commented Feb 8, 2025

These would otherwise give a warning after JuliaLang/julia#57311, but are a good change even independently.

These would otherwise give a warning after JuliaLang/julia#57311, but are a good change even independently.
@codecov
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (ff083ce) to head (87186f4).
Report is 13 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #598   +/-   ##
=======================================
  Coverage   84.06%   84.06%           
=======================================
  Files          12       12           
  Lines        9192     9192           
=======================================
  Hits         7727     7727           
  Misses       1465     1465           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ViralBShah ViralBShah merged commit 72c7cac into main Feb 8, 2025
10 checks passed
@ViralBShah ViralBShah deleted the kf/importconstructors branch February 8, 2025 15:53
@ViralBShah
Copy link
Member

This PR is included in SparseArrays on julia master, but it still seems to get the warnings

┌ SparseArrays
│  WARNING: Constructor for type "Matrix" was extended in `CHOLMOD` without explicit qualification or import.
│    NOTE: Assumed "Matrix" refers to `Base.Matrix`. This behavior is deprecated and may differ in future versions.`
│    NOTE: This behavior may have differed in Julia versions prior to 1.12.
│    Hint: If you intended to create a new generic function of the same name, use `function Matrix end`.
│    Hint: To silence the warning, qualify `Matrix` as `Base.Matrix` or explicitly `import Base: Matrix`
│  WARNING: Constructor for type "Vector" was extended in `CHOLMOD` without explicit qualification or import.
│    NOTE: Assumed "Vector" refers to `Base.Vector`. This behavior is deprecated and may differ in future versions.`
│    NOTE: This behavior may have differed in Julia versions prior to 1.12.
│    Hint: If you intended to create a new generic function of the same name, use `function Vector end`.
│    Hint: To silence the warning, qualify `Vector` as `Base.Vector` or explicitly `import Base: Vector`
└  

@ViralBShah ViralBShah added the backport 1.12 Change should be backported to release-1.12 label May 10, 2025
@dkarrasch dkarrasch removed the backport 1.12 Change should be backported to release-1.12 label May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants