Make cond(::SparseMatrix, 1 / Inf) discoverable from 2-norm error #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #629 +/- ##
==========================================
- Coverage 84.01% 84.01% -0.01%
==========================================
Files 12 12
Lines 9257 9256 -1
==========================================
- Hits 7777 7776 -1
Misses 1480 1480 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dkarrasch
reviewed
Aug 8, 2025
Member
|
I think this is helpful. @ViralBShah |
Co-authored-by: Daniel Karrasch <[email protected]>
Member
|
Yes should merge once CI is green. |
KristofferC
pushed a commit
that referenced
this pull request
Sep 22, 2025
Changed error message when trying to compute condition number of sparse matrix in 2-norm, suggesting 1 or Inf norm. Newbies like me or https://discourse.julialang.org/t/condition-number-of-sparse-matrix/77131/5 got diverted into trying densifying the array, which is very limited in many applications... --------- Co-authored-by: Viral B. Shah <[email protected]> Co-authored-by: Daniel Karrasch <[email protected]> (cherry picked from commit cff971d)
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed error message when trying to compute condition number of sparse matrix in 2-norm, suggesting 1 or Inf norm.
Newbies like me or https://discourse.julialang.org/t/condition-number-of-sparse-matrix/77131/5 got diverted into trying densifying the array, which is very limited in many applications...