Fix median for Binomial distribution
#1924
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix `median` for `Binomial`
devmotion
reviewed
Dec 13, 2024
Let `median(x::Binomial)` fall back to `quantile(x,1//2)`
Add test, remove `median` definition for `Binomial`
devmotion
reviewed
Dec 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1924 +/- ##
==========================================
- Coverage 85.99% 85.99% -0.01%
==========================================
Files 144 144
Lines 8685 8684 -1
==========================================
- Hits 7469 7468 -1
Misses 1216 1216 ☔ View full report in Codecov by Sentry. |
devmotion
reviewed
Dec 14, 2024
Member
devmotion
left a comment
devmotion
left a comment
There was a problem hiding this comment.
Thank you! I updated the tests against R as well which were affected by the same problem.
devmotion
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1923