Ekdist -- exponentiated Kumaraswamy#1951
Open
JJNewkirk wants to merge 14 commits intoJuliaStats:masterfrom
Open
Ekdist -- exponentiated Kumaraswamy#1951JJNewkirk wants to merge 14 commits intoJuliaStats:masterfrom
JJNewkirk wants to merge 14 commits intoJuliaStats:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1951 +/- ##
==========================================
- Coverage 86.36% 85.64% -0.72%
==========================================
Files 146 147 +1
Lines 8788 8863 +75
==========================================
+ Hits 7590 7591 +1
- Misses 1198 1272 +74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ararslan
reviewed
Jul 29, 2025
Member
ararslan
left a comment
There was a problem hiding this comment.
Some preliminary suggestions and comments, haven't reviewed everything at the moment.
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Co-authored-by: Alex Arslan <ararslan@comcast.net>
Author
|
All the suggestions were helpful and reasonable. Comitted as suggested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe my functions are accurate; however in testing the mean of the current kumaraswamy.jl the did not match in some cases. I believe this to be an error in the kumaraswamy.jl in the version I was using. The EK distribution has the Kumaraswamy as a special case, so it is easy to test keeping gamma = 1.