Fix R test references and make them reproducible #2007
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on adding a new distribution, I realized (once again) that the R test references can't be re-generated currently since running
Rscript gendref.R
errors:LindleyR
package is not available anymoredistr = StudentizedRange(...)
since the functiondistr$pdf
is undefinedtruncated(Normal(...), ...)
is not a valid reference name as it can't be mapped to a reference distributionMoreover, after commenting out these three reference distribution types rerunning
Rscript gendref.R
changes reference values for most distributions.This PR tries to fix the setup of the R reference tests:
renv
for a reproducible package environmentLindleyR
withnew.dist
package::function
syntax instead of relying onlibrary(package)
in other source filesStudentizedRange
by finite differencing of (log)cdfdistr$dtype
anddistr$expr
(to supporttruncated(...)
properly)StanHeaders
instead ofrstan
Erlang
andNormalCanon
)Rscript gendref.R