-
Notifications
You must be signed in to change notification settings - Fork 433
Adding missing features of cosine distribution #2017
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2017 +/- ##
==========================================
- Coverage 86.36% 86.33% -0.04%
==========================================
Files 146 146
Lines 8788 8805 +17
==========================================
+ Hits 7590 7602 +12
- Misses 1198 1203 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
devmotion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests for the new functionality?
Co-authored-by: David Müller-Widmann <[email protected]>
Co-authored-by: David Müller-Widmann <[email protected]>
Co-authored-by: David Müller-Widmann <[email protected]>
Co-authored-by: David Müller-Widmann <[email protected]>
|
I cleaned I added testing against some known simple values. Some more are needed or is this enough? My code was based on how the rest of cosine.jl looked like. When I saw your corrections the code above started looking suspicious for me and indeed, I'm also not sure about dependencies, but its' easy to change in any case. |
This is a very straightforward PR. It adds missing
mgf,cgf,cfand direct affine transformations for theCosinedistribution. There are simple formulas for these, so there is no reason not to include them.One thing which might require attention is if I protect from dividing by 0 correctly.