Rename wts to weights and allow passing variable name to it#631
Open
Rename wts to weights and allow passing variable name to it#631
wts to weights and allow passing variable name to it#631Conversation
This is particularly useful when some observations are dropped because of missing values. Also rename some internal arguments and variables. Drop support for non-`AbstractWeights` (which was deprecated in 1.9.1) but continue printing a helpful error message.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #631 +/- ##
==========================================
+ Coverage 96.93% 97.18% +0.25%
==========================================
Files 8 8
Lines 1206 1207 +1
==========================================
+ Hits 1169 1173 +4
+ Misses 37 34 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is particularly useful when some observations are dropped because of missing values. Also rename some internal arguments and variables.
Drop support for non-
AbstractWeights(which was deprecated in 1.9.1) but continue printing a helpful error message.Supersedes #570
Fixes #255
Fixes #350
Cc: @gragusa