Skip to content

add logabstanh function #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Aug 18, 2025
Merged

add logabstanh function #104

merged 14 commits into from
Aug 18, 2025

Conversation

@nsajko
Copy link
Contributor

@nsajko nsajko commented Aug 17, 2025 •
edited
Loading

Revive PR #86, but without the Float32-specific implementation and without the Float64-specific implementation.

Closes #86

oscardssmith and others added 14 commits November 16, 2024 02:35
@oscardssmith
add logabstanh
e8d075a
@oscardssmith
export
528545d
@oscardssmith @devmotion
Update src/basicfuns.jl
5cf0058 
Co-authored-by: David Widmann <[email protected]>
@oscardssmith @devmotion
Update src/basicfuns.jl
95639d1 
Co-authored-by: David Widmann <[email protected]>
@oscardssmith @devmotion
Update src/basicfuns.jl
3364d20 
Co-authored-by: David Widmann <[email protected]>
@oscardssmith @devmotion
Update src/basicfuns.jl
0b6d9f9 
Co-authored-by: David Widmann <[email protected]>
@nsajko
Merge branch 'master' into feature_logabstanh
9e05b65
@nsajko
include logabstanh doc string into the docs
938ef45
@nsajko
add ChainRules.jl rule for logabstanh
b318133
@nsajko
test ChainRules.jl rule for logabstanh
4c17c3b
@nsajko
test logabstanh: basicfuns
0207a15
@nsajko
avoid excessive promises in the logabstanh doc string
fc6617d
@nsajko
delete the precision-specific methods
39127b6 
They can be added back in a future PR as an optimization.
@nsajko
help logabstanh to be accurate near zero
00e2d63
@nsajko
Copy link
Contributor Author

nsajko commented Aug 17, 2025

without the Float32-specific implementation and without the Float64-specific implementation

My reasoning is that these are merely optimizations, so they can be considered separately in a future PR.

tpapp
tpapp approved these changes Aug 18, 2025
View reviewed changes
Copy link
Collaborator

@tpapp tpapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I agree that the specific optimizations can be left for future work.

@tpapp tpapp merged commit 04c9189 into JuliaStats:master Aug 18, 2025
4 checks passed
@nsajko nsajko deleted the feature_logabstanh branch August 18, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devmotion devmotion devmotion approved these changes

@tpapp tpapp tpapp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nsajko @devmotion @tpapp @oscardssmith