Skip to content

Conversation

@palday
Copy link
Member

@palday palday commented Jan 5, 2026

closes #872

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.
  • I've bumped the version appropriately

@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.62%. Comparing base (a30cf36) to head (2cf2f69).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   95.61%   95.62%           
=======================================
  Files          38       38           
  Lines        3694     3702    +8     
=======================================
+ Hits         3532     3540    +8     
  Misses        162      162           
Flag Coverage Δ
current 95.29% <100.00%> (+0.01%) ⬆️
minimum 95.56% <100.00%> (+<0.01%) ⬆️
nightly 95.29% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@palday palday marked this pull request as ready for review January 6, 2026 00:24
@palday palday requested a review from dmbates January 6, 2026 00:24
Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I am encouraged to see that you occasionally have "oops" commits too.

@palday palday merged commit e717b72 into main Jan 6, 2026
13 of 14 checks passed
@palday palday deleted the pa/glm-weights branch January 6, 2026 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests failing after change in GLM.jl where wts is no longer a synonym for the weights argument

3 participants