Skip to content

tests for cov/cor with missing #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests for cov/cor with missing #171

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -504,6 +504,34 @@ Y = [6.0 2.0;
@test isequal(cov([1 2; 2 3], [1, missing]), [missing missing]')
@test isequal(cov([1, missing], [1 2; 2 3]), [missing missing])
end

@testset "Inconsistencies in cor/cov with missing; issues #63 and #69" begin
@test (@inferred cor(Union{Float64, Missing}[missing])) === 1.0
@test_broken (@inferred cor([missing])) === 1.0
@test_broken (@inferred cor(Any[missing])) === 1.0

@test (@inferred cor([1])) === 1.0
@test_broken (@inferred cor(Any[1])) === 1.0

@test ismissing(cov([1., missing, 1.]))
@test_broken ismissing(@inferred Float64 cov([1., missing, 1.]))
@test isequal(cov([missing 1.; 2. 3.]), [missing missing; missing 2.0])
@test isequal(cov([1. missing; 2. 3.]), [0.5 missing; missing missing])
@test isequal(cov([1. 2.; missing 3.]), [missing missing; missing 0.5])
@test isequal(cov([1. 2.; 3. missing]), [2.0 missing; missing missing])


@test (@inferred Float64 cor([1., missing, 1.])) === (@inferred cor([1., NaN, 1.])) === 1.0
@test isequal(cor([missing 1.; 2. 3.]), [1.0 missing; missing 1.0])
@test isequal(cor([1. missing; 2. 3.]), [1.0 missing; missing 1.0])
@test isequal(cor([1. 2.; missing 3.]), [1.0 missing; missing 1.0])
@test isequal(cor([1. 2.; 3. missing]), [1.0 missing; missing 1.0])

for n in 1:10
@test isequal((@inferred cor(fill(missing, n,n))), fill(missing, n,n))
@test isequal((@inferred cov(fill(missing, n,n))), fill(missing, n,n))
end
end
end

function safe_cor(x, y, zm::Bool)
Expand Down