Skip to content

Remove unreliable test #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devmotion merged 2 commits into from
Jan 7, 2026
Merged

Remove unreliable test #967

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
551243f
Remove unreliable test
devmotion Oct 14, 2025
c600cd7
Merge branch 'master' into dw/clean_test
devmotion Oct 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/cov.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ function test_isapprox_preserves_symherm_structure(f::F, x::AbstractMatrix, y::A
if A isa Union{Symmetric,Hermitian}
@test fA isa (A isa Symmetric ? Symmetric : Hermitian)
@test fA.uplo == A.uplo
@test parent(fA) != fA # only active triangle is written to
Copy link
Member

@nalimilan nalimilan Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's the same line in the branch above, shouldn't it be removed too?

Copy link
Member Author

@devmotion devmotion Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test in the branch above should be fine since it's for the in-place methods: In these cases, as tested, fA === A but since A is created by copying (and potentially wrapping) a properly initialised matrix, the parent could only be equal to the wrapped array after the cov2cor!/cor2cov! call if all standard deviations are one.

end
end
end
Expand Down
Loading