Reduce allocations #266
Draft
Reduce allocations #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaqz
force-pushed
the
reduce_allocations
branch
from
e01b872 to
5c2fecf
Compare
ararslan
reviewed
Oct 26, 2022
| @@ -53,22 +53,26 @@ end | |||
| _missing_omit(x::AbstractVector{T}) where T = copyto!(similar(x, nonmissingtype(T)), x) | |||
There was a problem hiding this comment.
If I recall, the fact that this makes a copy even if T doesn't allow Missing was intentional to ensure that every column gets copied and downstream users of this function can mutate the result without worrying about affecting the original data. If we don't care about that, we can do
Suggested change
| _missing_omit(x::AbstractVector{T}) where T = copyto!(similar(x, nonmissingtype(T)), x) | |
| _missing_omit(x::AbstractVector{T}) where {T>:Missing} = copyto!(similar(x, nonmissingtype(T)), x) | |
| _missing_omit(x::AbstractVector{T}) where {T} = x |
without needing any other changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces array allocations for some nice performance improvements. It makes
missing_omit_maybe_missing_omit, which does nothing when none of the columns haveMissingeltypes.I suspect
modelcolscan be much further optimized by reallocating and using a loop rather thanreduce(vcat, x). I may add that too - this the main performance bottleneck after this PR.