Skip to content

Remove unused MurmurHash3 dependency #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −12
Open

Remove unused MurmurHash3 dependency #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions LICENSE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ This also incorporates a large amount of code from various PRs I made, which wer
| [#12898](https://github.com/JuliaLang/julia/pull/12898) | Add coverage tests for strings/basic.jl |
| [#12905](https://github.com/JuliaLang/julia/pull/12905) | Deprecate getindex/checkbounds methods for non Integer Real indices for Chars and Strings |

The Julia implementation of MurmurHash3 was based on [MurmurHash3](https://github.com/JuliaLang/julia/blob/master/src/support/MurmurHash3.c) by Autin Appleby, which was placed in the public domain.

Some of the ideas for the design and how to implement came from collaborating on the [StringEncodings](https://github.com/nalimilan/StringEncodings.jl) package, by [Milan Bouchet-Valat](https://github.com/nalimilan) and the [Strings](https://github.com/quinnj/Strings.jl) package, by [Jacob Quinn](https://github.com/quinnj)

The [JuliaString logo(s)](Logo.gif) are copyright (c) 2018 [@cormullion](https://github.com/cormullion) (Julia artist extraordinaire: math + code + Julia -> visual poetry)
Expand Down
3 changes: 0 additions & 3 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ StrEntities = "42b7a45b-8021-5b99-aff5-7432580bee1c"
Format = "1fa38f19-a742-5d3f-a2b9-30dd87b9d5f8" # 9wb580eyjv4k3iej
StrFormat = "b5087856-efa9-5a6d-8e6f-97303a7af894"

MurmurHash3 = "b10b62ed-fbae-5ea5-b934-abaf0477b71d"

StrAPI = "69e7dfc3-c4d0-5e14-8d95-d6042a05b383"
ChrBase = "c13fa7b1-fb91-5a40-8b3c-3aad7fd30002"
StrBase = "e79e7a6a-7bb1-5a4d-9d64-da657b06f53a"
Expand Down Expand Up @@ -54,7 +52,6 @@ StrFormat = "^1.0.1"
StrRegex = "^1.1.1"
StrLiterals = "^1.1"
ChrBase = "^1.0.3"
MurmurHash3 = "^1.2"
Emoji_Entities = "^1.0.3"
HTML_Entities = "^1.0.1"
LaTeX_Entities = "^1.0.2"
Expand Down
7 changes: 0 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ or pointers to such (such as a way to get lots of tweets, to test mixed text and
| [StrAPI][strapi-loc] | [![][strapi-rel]][strapi-loc] | [![][strapi-dat]][strapi-loc] | [![][strapi-pkg]][pkg-url] | [![][strapi-chk]][strapi-loc] | Common API for string/character functionality
| [CharSetEncodings][cse-loc] | [![][cse-rel]][cse-loc] | [![][cse-dat]][cse-loc] | [![][cse-pkg]][pkg-url] | [![][cse-chk]][cse-loc] | Basic types/support for Character Sets, Encodings, and Character Set Encodings
| [ChrBase][chrbase-loc] | [![][chrbase-rel]][chrbase-loc] | [![][chrbase-dat]][chrbase-loc] | [![][chrbase-pkg]][pkg-url] | [![][chrbase-chk]][chrbase-loc] | `Chr{CharSet,CodeUnitType}` type and support
| [MurmurHash3][mh3-loc] | [![][mh3-rel]][mh3-loc] | [![][mh3-dat]][mh3-loc] | [![][mh3-pkg]][pkg-url] | [![][mh3-chk]][mh3-loc] | Pure Julia implementation of MurmurHash3
| [PCRE2][pcre2-loc] | [![][pcre2-rel]][pcre2-loc] | [![][pcre2-dat]][pcre2-loc] | [![][pcre2-pkg]][pkg-url] | [![][pcre2-chk]][pcre2-loc] | `PCRE2` library support
| [Format][format-loc] | [![][format-rel]][format-loc] | [![][format-dat]][format-loc] | [![][format-pkg]][pkg-url] | [![][format-chk]][format-loc] | Python/C style formatting (based on [Formatting](https://github.com/JuliaIO/Formatting.jl))
| [StrBase][strbase-loc] | [![][strbase-rel]][strbase-loc] | [![][strbase-dat]][strbase-loc] | [![][strbase-pkg]][pkg-url] | [![][strbase-chk]][strbase-loc] | `Str{CSE, Hash, SubSet, Cache}` type
Expand All @@ -97,12 +96,6 @@ or pointers to such (such as a way to get lots of tweets, to test mixed text and
[mit-dat]: https://img.shields.io/github/release-date/JuliaString/ModuleInterfaceTools.jl.svg?label="."
[mit-chk]: https://img.shields.io/github/checks-status/JuliaString/ModuleInterfaceTools.jl/master

[mh3-loc]: https://github.com/JuliaString/MurmurHash3.jl
[mh3-pkg]: https://juliaci.github.io/NanosoldierReports/pkgeval_badges/M/MurmurHash3.svg
[mh3-rel]: https://img.shields.io/github/release/JuliaString/MurmurHash3.jl.svg?label="."
[mh3-dat]: https://img.shields.io/github/release-date/JuliaString/MurmurHash3.jl.svg?label="."
[mh3-chk]: https://img.shields.io/github/checks-status/JuliaString/MurmurHash3.jl/master

[pcre2-loc]: https://github.com/JuliaString/PCRE2.jl
[pcre2-pkg]: https://juliaci.github.io/NanosoldierReports/pkgeval_badges/P/PCRE2.svg
[pcre2-rel]: https://img.shields.io/github/release/JuliaString/PCRE2.jl.svg?label="."
Expand Down
Loading