Skip to content

Fix warnings at compile time #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 7, 2025
Merged

Fix warnings at compile time #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ef891a3
Update rules count badge [skip ci]
github-actions[bot] Sep 10, 2025
e9620db
remove warning "declares type variable F but does not use it"
Bumblebee00 Nov 7, 2025
a1dcfaa
remove warning "Method definition expinti"
Bumblebee00 Nov 7, 2025
e098325
removed other special function registration (it's already done in Sym…
Bumblebee00 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/badges/rules-count.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"schemaVersion": 1,
"label": "Total rules",
"message": "3399",
"message": "3400",
"color": "blue"
}
3 changes: 1 addition & 2 deletions src/methods/risch/frontend.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -661,8 +661,7 @@ Base.promote(x::MPolyRingElem{Nemo.QQBarFieldElem}, y::QQFieldElem) = promote(x,



function TowerOfDifferentialFields(terms::Vector{Term}) where
{T<:FieldElement, P<:MPolyRingElem{T}, F<:FracElem{P}}
function TowerOfDifferentialFields(terms::Vector{Term})
n = length(terms)
MF = parent(terms[1].arg)
MR = base_ring(MF)
Expand Down
24 changes: 11 additions & 13 deletions src/methods/rule_based/general.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,15 @@
# ===== Special functions from a lot of packages
# TODO extension to Symbolics?

# function from SpecialFunctions.jl that are not yet registered
@register_symbolic SymbolicUtils.expinti(x)
@register_symbolic SymbolicUtils.expint(nu, z)
@register_symbolic SymbolicUtils.gamma(x, y)
@register_symbolic SymbolicUtils.sinint(x)
@register_symbolic SymbolicUtils.cosint(x)
# other from SpecialFunctions.jl used:
# SymbolicUtils.gamma(x)
# SymbolicUtils.loggamma
# SymbolicUtils.erfi
# SymbolicUtils.erf

# function from SpecialFunctions.jl used:
# SpecialFunctions.expinti(x)
# SpecialFunctions.expint(nu, z)
# SpecialFunctions.gamma(x, y)
# SpecialFunctions.sinint(x)
# SpecialFunctions.cosint(x)
# SpecialFunctions.gamma(x)
# SpecialFunctions.loggamma
# SpecialFunctions.erfi
# SpecialFunctions.erf

using Elliptic
@register_symbolic Elliptic.F(phi, m) # incomplete first kind
Expand Down
Loading