-
Notifications
You must be signed in to change notification settings - Fork 3
Faster rules #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Faster rules #53
Conversation
|
Yep, Mattia and I are discussing this on Slack. It's potentially promising, at the very least until we get better rules in SU (which will take a while) |
|
ok so i improved the new rule mechanism to a almost working state:
Then I converted about 600 rules to the new mechanism and tested the loading time. Old (loading only the same ~600 rules as above): |
|
it faster 😁😁😁, now remains to test only the time it takes to apply them |
|
Ok so the other problem that this pr amis to solve is the TTFX because the first integrate call is sooo slow. I did NOT yet come up with a way to measure this (btw @ChrisRackauckas @AayushSabharwal if you have suggestions on how to properly benchmark ttfx tell me), but in the meanwhile I benchmarked the normal execution time (not the first). I repeat, this pr doesnt aim to improve the "average" execution time, only the first. but I am pleased to see that the average execution time it's on the same "order of magnitude" of the old rule system, even a bit faster. Trying the resolution of the integral Old: New: |
|
another important thing to mention is that updating the package to work with SUv4 is a bit more work than expected |
|
The one thing i came up with to benchmark the ttfx is creating a simple script and then running So we have:
where the last row is time it takes to compute the first integrate call, the part that should be improved by specifying all the types so that type inference is fast. Remember that this is still using a subset of the total rules (600/3400). I am pleased to see that is faster 😁😁😁
New: |
New mechanism for rules, that aims to be much faster. Currently still a expermient