Migrate to Moshi.jl #676
Draft
Migrate to Moshi.jl #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akirakyle
force-pushed
the
moshi
branch
2 times, most recently
from
fc753e0 to
62feb58
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental branch inspired by the work in #617 to replace Unityper.jl with Moshi.jl allowing all the
BasicSymbolictypes to be defined as recursive algebraic data types. Most of the tests are passing, although I still have some unanswered questions about the best way to utilize Moshi.jl and some potential issues such as Roger-luo/Moshi.jl#32Anyways I thought I would submit this as a draft in case there's any useful discussion that could happen at this point.