Refactor `BasicSymbolic` struct to separate metadata from hash consing #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft

bowenszhu wants to merge 26 commits into master from b/struct-refactor

src/code.jl

-Original file line number
+Diff line change
@@ Expand Up / @@ -717,6 +717,9 @@ function topological_sort(graph) @@
         visited = IdDict()
         function dfs(node)
+            if node isa BasicSymbolic
+                node = node.expr
+            end
             if haskey(visited, node)
                 return visited[node]
             end
@@ Expand Down @@