- 
                Notifications
    
You must be signed in to change notification settings  - Fork 2
 
Add progress indication and ETA status line. #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
           Needs some locking to not compete against Distributed.jl printing worker messages: ... but naively taking the   | 
    
d7d5016    to
    d42285f      
    Compare
  
    | 
           Turns out IOCapture, as introduced in #25, is somehow incompatible with Distributed. On this PR, running  Anyway, I decided to add   | 
    
      
        
              This comment was marked as resolved.
        
        
      
    
  This comment was marked as resolved.
| using Test, IOCapture | ||
| using Test | ||
| 
               | 
          ||
| cd(@__DIR__) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this cd necessary?  If I remove it, tests are still successful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In order to support running tests out of tree, e.g., doing julia --project test/runtests.jl. Just a little convenience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see, yes, I can reproduce that. But I'd say this is something that this package could handle more nicely in principle by making the tests more working-directory-independent, but haven't looked into what's going on. In any case this issue is orthogonal to this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To get colourful output, like in #27.
| 
           One thing which isn't clear to me is where the message is coming from (i.e. which worker/job is printing it). Is that Metal.jl? Do you have a branch for us to test this locally?  | 
    
| 
           Output is now printed when a testset finishes, so it's from the worker listed above. Metal.jl WIP: https://github.com/JuliaGPU/Metal.jl/tree/tb/paralleltestrunner  | 
    
| 
           Alternative: Maybe that's clearer?  | 
    
Co-authored-by: Mosè Giordano <[email protected]>
Co-authored-by: Mosè Giordano <[email protected]>
26883a0    to
    25a22ba      
    Compare
  
    25a22ba    to
    86b4b44      
    Compare
  
    86b4b44    to
    abf77ec      
    Compare
  
    | 
           I'm occasionally seeing: ... which I'm not sure how to explain  | 
    
| 
           Very cool!  | 
    


Significant refactor of the output tasks in order to make it possible to output additional info. The architecture switches to a separate task that's responsible for all the printing, with data sent to over a channel from several executor tasks.
Fixes #26
Fixes #13