- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2
Add WorkerTestSet to avoid loss of context due to TestSetException #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| No new macro is definitely better! How does the WorkerTestSet not get propagated to the rest of the testsets? Edit: It does :/ Running 2 tests in parallel. If this is too many, specify the `--jobs=N` argument to the tests, or set the `JULIA_CPU_THREADS` environment variable.
               │          │ ──────────────── CPU ──────────────── │
Test  (Worker) │ Time (s) │ GC (s) │ GC % │ Alloc (MB) │ RSS (MB) │
mps/size   (2) │     0.62 │   0.01 │  0.9 │      66.50 │   580.78 │
mtl/size   (1) │     0.64 │   0.01 │  0.9 │      67.05 │   579.80 │
Test Summary: | Error  Total  Time
  Overall     |     2      2  7.4s
    mps/size  |     1      1  6.2s
    mtl/size  |     1      1  6.5s
    FAILURE
Error in testset mps/size:
Error During Test at /Users/christian/.julia/dev/ParallelTestRunner/src/ParallelTestRunner.jl:255
  Got exception outside of a @test
  LoadError: AssertionError: Test.get_testset_depth() == 0 | 
| 
 You should take my  ParallelTestRunner.jl/src/ParallelTestRunner.jl Lines 1006 to 1007 in 681ae1a 
 | 
| Urgh, propagating the custom Testset is an understandable, yet annoying move. | 
| @christiangnrd we have now converged to something very similar :) Okay, if I merge this, and can I add you as a co-author to the merge commit? | 
| Can add a test for the stacktrace? | 
| 
 That works for me | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Co-authored-by: Christian Guinard <[email protected]>
Co-authored-by: Christian Guinard <[email protected]>
Fixes #32