dryrun: filter isfinal testsets even with unknown subjects

I.e. a testset can have a `missing` subject, but still have to be
filtered out: e.g. with a "duplicity" loop, in the face of the
`iter(n)` pattern (see added tests for details).

Author: rfourquet

src/ReTest.jl

@@ -1452,7 +1452,8 @@ module_summary(verbose, many) = many | iszero(verbose)
 # FIXME: isfor when only one iteration
 hasmany(tests) = length(tests) > 1 || isfor(tests[1])
 
-function dryrun(mod::Module, ts::TestsetExpr, pat::Pattern, align::Int=0, parentsubj=""
+function dryrun(mod::Module, ts::TestsetExpr, pat::Pattern, align::Int=0,
+                parentsubj::Union{Missing, String}=""
                 ; maxidw::Int, marks::Bool, clear::Bool, # external calls
                 # only recursive calls:
                 evaldesc=true, repeated=nothing, show::Bool=true)
@@ -1467,12 +1468,10 @@ function dryrun(mod::Module, ts::TestsetExpr, pat::Pattern, align::Int=0, parent
             end
         end
 
-        subject = nothing
-        if parentsubj isa String && desc isa String
-            subject = parentsubj * '/' * desc
-            if isfinal(ts) && !matches(pat, subject, ts)
-                return false, false, false
-            end
+        subject = desc isa String ? parentsubj * "/" * desc :
+                                    missing
+        if isfinal(ts) && false === matches(pat, subject, ts)
+            return false, false, false
         end
 
         res = pastresult(ts.marks, subject)

test/runtests.jl

@@ -789,6 +789,18 @@ a
   "b?" (repeated 1 times)
     c
 """)
+
+    # in dryrun mode, isfinal testsets might have to be filtered out even when
+    # their description can't be interpolated (finding such an example was initial
+    # motivation to add the iter(n)::Iter pattern)
+    check(MiscDuplicity, (2, iter(1)), dry=true, id=false, verbose=2, [], output="""
+a
+  b1
+""")
+    check(MiscDuplicity, (2, iter(2)), dry=true, id=false, verbose=2, [], output="""
+a
+  "b?" (repeated 1 times)
+""")
 end
 
 module MV # MiscVerbose, but we want the name to be short to not have effect on alignment